From: Adrian Hunter <adrian.hunter@intel.com>
To: Troy Kisky <troy.kisky@boundarydevices.com>, aisheng.dong@nxp.com
Cc: ulf.hansson@linaro.org, linux-mmc@vger.kernel.org,
fabio.estevam@nxp.com, gary.bisson@boundarydevices.com
Subject: Re: [PATCH] mmc: sdhci: clear interrupt when retune interrupt received
Date: Fri, 9 Jun 2017 15:46:55 +0300 [thread overview]
Message-ID: <9b1a2764-e348-b032-a61b-e2c09286aa0a@intel.com> (raw)
In-Reply-To: <1496947916-15785-1-git-send-email-troy.kisky@boundarydevices.com>
On 08/06/17 21:51, Troy Kisky wrote:
> This lets the loop exit before max_loops reaches 0.
Needs more explanation.
>
> Fixes: f37b20ebc4bc ("mmc: sdhci: add standard hw auto retuning support")
>
> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> ---
> drivers/mmc/host/sdhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index ecd0d43..e104194 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -2687,7 +2687,7 @@ static irqreturn_t sdhci_irq(int irq, void *dev_id)
>
> /* Clear selected interrupts. */
> mask = intmask & (SDHCI_INT_CMD_MASK | SDHCI_INT_DATA_MASK |
> - SDHCI_INT_BUS_POWER);
> + SDHCI_INT_BUS_POWER | SDHCI_INT_RETUNE);
SDHCI_INT_RETUNE is defined to be read-only so why write to it.
> sdhci_writel(host, mask, SDHCI_INT_STATUS);
>
> if (intmask & (SDHCI_INT_CARD_INSERT | SDHCI_INT_CARD_REMOVE)) {
>
next prev parent reply other threads:[~2017-06-09 12:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-08 18:51 [PATCH] mmc: sdhci: clear interrupt when retune interrupt received Troy Kisky
2017-06-09 12:46 ` Adrian Hunter [this message]
2017-06-09 15:45 ` Troy Kisky
2017-06-12 12:33 ` Adrian Hunter
2017-06-12 14:03 ` A.S. Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b1a2764-e348-b032-a61b-e2c09286aa0a@intel.com \
--to=adrian.hunter@intel.com \
--cc=aisheng.dong@nxp.com \
--cc=fabio.estevam@nxp.com \
--cc=gary.bisson@boundarydevices.com \
--cc=linux-mmc@vger.kernel.org \
--cc=troy.kisky@boundarydevices.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox