From: Adrian Hunter <adrian.hunter@intel.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
linux-mmc@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] mmc: sdhci-msm: add static to local functions
Date: Thu, 3 Aug 2017 13:31:50 +0300 [thread overview]
Message-ID: <9cd06301-68c1-ce6f-c156-52a4f86ba7dd@intel.com> (raw)
In-Reply-To: <1501502446-13931-1-git-send-email-yamada.masahiro@socionext.com>
On 31/07/17 15:00, Masahiro Yamada wrote:
> Detected by sparse.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
>
> drivers/mmc/host/sdhci-msm.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c
> index 9d601dc0d646..f35db061ee4c 100644
> --- a/drivers/mmc/host/sdhci-msm.c
> +++ b/drivers/mmc/host/sdhci-msm.c
> @@ -611,7 +611,7 @@ static void msm_hc_select_hs400(struct sdhci_host *host)
> * HS400 - divided clock (free running MCLK/2)
> * All other modes - default (free running MCLK)
> */
> -void sdhci_msm_hc_select_mode(struct sdhci_host *host)
> +static void sdhci_msm_hc_select_mode(struct sdhci_host *host)
> {
> struct mmc_ios ios = host->mmc->ios;
>
> @@ -1049,7 +1049,7 @@ static unsigned int sdhci_msm_get_min_clock(struct sdhci_host *host)
> * instead directly control the GCC clock as per
> * HW recommendation.
> **/
> -void __sdhci_msm_set_clock(struct sdhci_host *host, unsigned int clock)
> +static void __sdhci_msm_set_clock(struct sdhci_host *host, unsigned int clock)
> {
> u16 clk;
> /*
>
next prev parent reply other threads:[~2017-08-03 10:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-31 12:00 [PATCH] mmc: sdhci-msm: add static to local functions Masahiro Yamada
2017-08-03 10:31 ` Adrian Hunter [this message]
2017-08-03 10:51 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cd06301-68c1-ce6f-c156-52a4f86ba7dd@intel.com \
--to=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox