From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4D0DFA3740 for ; Mon, 24 Oct 2022 19:36:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233364AbiJXTgb (ORCPT ); Mon, 24 Oct 2022 15:36:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233375AbiJXTgC (ORCPT ); Mon, 24 Oct 2022 15:36:02 -0400 Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB1AB20B109; Mon, 24 Oct 2022 11:06:38 -0700 (PDT) Received: by mail-qk1-x731.google.com with SMTP id z30so6533639qkz.13; Mon, 24 Oct 2022 11:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8uZ3VwfktP6MlXqcTSmXnIQiEYTG6oe41z15jnyDxAg=; b=hUQNLA+Bt+iC3EXWYW6u4ZiXQN+8gSkbnmx8T2s8gwIyjYMlb9xie2OOJHwqqdlE6g TPMX8YiSGrjcgbVnTCnFsXG5p9TyBfNZW9cG8k8CcqbzN2bmQnheWRACOBZ/d0Ypyji3 rAeT3VRnZNw4YbeuVXZ3vEOKtNVMeNwXu/MjHy95n+2bxkdGNTOtyJszmv75cO39QUVX 3tMEuxZT7eSOq8Es/EwqZssEHzAuhydL/i7aK2CmAmpvk3RmjxlZZXCchdX4A7oDcSBj OT7wE6byf63cJL5bI9VHwdG17EIHCSUqDNg2p48fauR7p1cAjQNOcc/NytgEWglrxAdz RDuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8uZ3VwfktP6MlXqcTSmXnIQiEYTG6oe41z15jnyDxAg=; b=bUP25NxnLhhgdkAEChATBRfSvbrFj+ptOJAywytSQ8l1vQfyP3dXWWybikCuk3DzqU i3WF41K8z/odAVa8QowcLt6aT1NhAvu+eVb2uc/QivF3FHB4dQjYXbC+OIu9r+2j31VF SBHOa90obRFXG71PYCOlTFPUkELB5EmAX5Q1bbp5vta9m3pP3I6HiemJgTxop1dT8ndV fywFPkaaOq+I4QB6RRgKVkB/EFKXZZusJUhFJhbzNlEJv8INeCJPcqiE06LiylGpInko nUm0+Q6gVo9kh1rkpngkKj9685txVp5aCuMfnGqOVNdUKqocIS8DFV9b1askCBLRn/Fr rUPg== X-Gm-Message-State: ACrzQf2ddP56skGqBg9VG0k5XKDMnXCdC/2qXJqiQV8QZ7B2VyAyoRTV QWHBIO2MJSaQDIELVpp4WG4= X-Google-Smtp-Source: AMsMyM6VD3e4iOCRwH+WEfJk7Le9i9P05UDL6cK9G/xPqVkJKTVIOyBY4IzI1tu67LqNtF/xB4eU0A== X-Received: by 2002:a05:620a:24d5:b0:6ee:d4bb:e5ba with SMTP id m21-20020a05620a24d500b006eed4bbe5bamr23818286qkn.457.1666634695655; Mon, 24 Oct 2022 11:04:55 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id e10-20020a05622a110a00b0039cb9ef50b5sm335003qty.26.2022.10.24.11.04.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Oct 2022 11:04:55 -0700 (PDT) Message-ID: <9e15ffc5-fda9-b2c2-97f1-866c51bde113@gmail.com> Date: Mon, 24 Oct 2022 11:04:42 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3 3/7] mmc: sdhci-brcmstb: Fix SDHCI_RESET_ALL for CQHCI Content-Language: en-US To: Brian Norris , Ulf Hansson Cc: Shawn Lin , linux-mmc@vger.kernel.org, Al Cooper , Bjorn Andersson , Sowjanya Komatineni , Broadcom internal kernel review list , Sascha Hauer , Konrad Dybcio , Florian Fainelli , NXP Linux Team , Thierry Reding , Fabio Estevam , Michal Simek , linux-kernel@vger.kernel.org, Shawn Guo , Adrian Hunter , Pengutronix Kernel Team , linux-arm-msm@vger.kernel.org, Haibo Chen , Andy Gross , linux-arm-kernel@lists.infradead.org, Faiz Abbas , Jonathan Hunter References: <20221024175501.2265400-1-briannorris@chromium.org> <20221024105229.v3.3.I6a715feab6d01f760455865e968ecf0d85036018@changeid> From: Florian Fainelli In-Reply-To: <20221024105229.v3.3.I6a715feab6d01f760455865e968ecf0d85036018@changeid> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On 10/24/22 10:54, Brian Norris wrote: > [[ NOTE: this is completely untested by the author, but included solely > because, as noted in commit df57d73276b8 ("mmc: sdhci-pci: Fix > SDHCI_RESET_ALL for CQHCI for Intel GLK-based controllers"), "other > drivers using CQHCI might benefit from a similar change, if they > also have CQHCI reset by SDHCI_RESET_ALL." We've now seen the same > bug on at least MSM, Arasan, and Intel hardware. ]] > > SDHCI_RESET_ALL resets will reset the hardware CQE state, but we aren't > tracking that properly in software. When out of sync, we may trigger > various timeouts. > > It's not typical to perform resets while CQE is enabled, but this may > occur in some suspend or error recovery scenarios. > > Include this fix by way of the new sdhci_and_cqhci_reset() helper. > > Fixes: d46ba2d17f90 ("mmc: sdhci-brcmstb: Add support for Command Queuing (CQE)") > Signed-off-by: Brian Norris Reviewed-by: Florian Fainelli -- Florian