From: Daniel Drake <dsd@laptop.org>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>
Subject: Re: MMC runtime PM patches break libertas probe
Date: Sat, 6 Nov 2010 21:19:49 +0000 [thread overview]
Message-ID: <AANLkTi=GjQUOBBWe96ubtxN+ndQLcOFjebrDkM_1hSSb@mail.gmail.com> (raw)
In-Reply-To: <AANLkTi=EaZbdnJzJWGH2fUadvNkUhdQgTU1rAoS5wMAs@mail.gmail.com>
On 1 November 2010 08:27, Ohad Ben-Cohen <ohad@wizery.com> wrote:
>> On such boards, the right thing to do would be to disable runtime PM altogether.
>
> The patch below (/attached) should trivially fix the problem - can you
> please check it out ?
Thanks.
It solves the problem.
But, what you point out is quite interesting.
We currently have a (not-yet-upstream) rfkill driver for the XO-1.5,
which we also put in place for power saving reasons. It operates by
calling mmc_stop_host(). In light of your work, I guess that wasn't
really turning off the card.
So, it would be great if you could get runtime PM working on this
combo, and then later we could make a real rfkill driver.
I guess you have an XO-1.5 now. I'm happy to help you get started, I
guess this is your first time working with an XO. Drop by irc.oftc.net
#olpc-devel and I'll happily help you get started booting your own
kernel etc.
Thanks!
Daniel
next prev parent reply other threads:[~2010-11-06 21:19 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-31 14:29 MMC runtime PM patches break libertas probe Daniel Drake
2010-10-31 14:42 ` Ohad Ben-Cohen
2010-10-31 14:55 ` Daniel Drake
2010-10-31 15:08 ` Ohad Ben-Cohen
2010-10-31 15:10 ` Daniel Drake
2010-10-31 15:16 ` Ohad Ben-Cohen
2010-10-31 15:21 ` Daniel Drake
2010-10-31 15:21 ` Daniel Drake
2010-10-31 15:27 ` Ohad Ben-Cohen
2010-10-31 15:57 ` Daniel Drake
2010-10-31 16:16 ` Ohad Ben-Cohen
2010-10-31 16:24 ` Daniel Drake
2010-10-31 19:06 ` Ohad Ben-Cohen
2010-11-01 8:27 ` Ohad Ben-Cohen
2010-11-06 21:19 ` Daniel Drake [this message]
2010-11-07 1:48 ` Nicolas Pitre
2010-11-07 10:19 ` Daniel Drake
2010-11-07 15:12 ` Nicolas Pitre
2010-11-07 10:42 ` Ohad Ben-Cohen
2010-11-07 10:51 ` Daniel Drake
2010-11-07 13:17 ` Ohad Ben-Cohen
2010-11-16 13:22 ` Ohad Ben-Cohen
2010-11-16 14:29 ` Daniel Drake
2010-11-16 14:49 ` Ohad Ben-Cohen
2010-11-17 6:46 ` Mike Rapoport
2010-11-17 7:29 ` Ohad Ben-Cohen
2010-11-17 14:54 ` Nicolas Pitre
2010-11-16 17:17 ` Arnd Hannemann
2010-11-16 20:58 ` Ohad Ben-Cohen
2010-11-16 21:16 ` Arnd Hannemann
2010-11-16 22:26 ` Ohad Ben-Cohen
2011-05-29 16:21 ` Daniel Drake
2011-05-30 6:52 ` Ohad Ben-Cohen
2011-05-30 7:01 ` Daniel Drake
2011-05-30 7:32 ` Ohad Ben-Cohen
2011-05-30 11:04 ` zhangfei gao
2011-05-30 11:16 ` Ohad Ben-Cohen
2011-06-02 8:39 ` Bing Zhao
2011-06-02 18:25 ` Ohad Ben-Cohen
2011-06-03 22:28 ` Bing Zhao
2011-06-03 22:52 ` Ohad Ben-Cohen
2011-06-07 14:34 ` Arnd Hannemann
2011-06-07 14:45 ` Ohad Ben-Cohen
2011-06-08 14:34 ` Ohad Ben-Cohen
2011-06-10 2:02 ` zhangfei gao
2011-06-10 4:28 ` Ohad Ben-Cohen
2011-06-11 2:33 ` zhangfei gao
2011-06-11 9:03 ` Ohad Ben-Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=GjQUOBBWe96ubtxN+ndQLcOFjebrDkM_1hSSb@mail.gmail.com' \
--to=dsd@laptop.org \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).