From: Andrei Warkentin <andreiw@motorola.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-mmc@vger.kernel.org
Subject: Re: [RFC 2/5] MMC: Allow function-specific quirks.
Date: Thu, 10 Mar 2011 14:41:45 -0600 [thread overview]
Message-ID: <AANLkTi=HBwXQL125Zat-wAcZYFE5ZKy9bUzqBfp+sB_u@mail.gmail.com> (raw)
In-Reply-To: <201103101609.28223.arnd@arndb.de>
On Thu, Mar 10, 2011 at 9:09 AM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Thursday 10 March 2011, Andrei Warkentin wrote:
>>
>> This allows us to create quirks for block devices, without
>> creating messy Kconfig dependencies, or polluting core/ with
>> function-specific code.
>
> The change looks good to me, but it's hard to read because
> you are moving around code and changing it in one patch.
>
> A better split of the first three patches would be to first
> move the code to a header file without changing it, and then
> make the changes.
>
> Or you could directly add the code to the header file when you
> introduce it in the first patch.
So basically squash the three patches dealing with quirks infrastructure?
A
next prev parent reply other threads:[~2011-03-10 20:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-10 0:54 Block quirks redux + Toshiba performance quirk Andrei Warkentin
2011-03-10 0:12 ` Andrei Warkentin
2011-03-10 0:54 ` [RFC 1/5] MMC: Extends card quicks with MMC/SD quirks matching the CID Andrei Warkentin
2011-03-10 0:54 ` [RFC 2/5] MMC: Allow function-specific quirks Andrei Warkentin
2011-03-10 15:09 ` Arnd Bergmann
2011-03-10 20:41 ` Andrei Warkentin [this message]
2011-03-10 21:55 ` Arnd Bergmann
2011-03-10 0:54 ` [RFC 3/5] MMC: Support for block quirks Andrei Warkentin
2011-03-10 0:54 ` [RFC 4/5] MMC: Adjust unaligned write accesses Andrei Warkentin
2011-03-10 16:05 ` Arnd Bergmann
2011-03-10 20:45 ` Andrei Warkentin
2011-03-10 21:54 ` Arnd Bergmann
2011-03-10 23:06 ` Andrei Warkentin
2011-03-11 10:23 ` Arnd Bergmann
2011-03-13 13:00 ` Andrei Warkentin
2011-03-13 14:54 ` Arnd Bergmann
2011-03-14 7:40 ` Andrei Warkentin
2011-03-19 11:09 ` Andrei Warkentin
2011-03-21 14:21 ` Arnd Bergmann
2011-03-21 14:41 ` Andrei Warkentin
2011-03-21 18:03 ` Andreas Dilger
2011-03-21 19:05 ` Arnd Bergmann
2011-03-21 23:58 ` Andreas Dilger
2011-03-22 13:56 ` Arnd Bergmann
2011-03-22 15:02 ` Andreas Dilger
2011-03-22 15:44 ` Arnd Bergmann
2011-03-10 0:54 ` [RFC 5/5] MMC: Toshiba eMMC - Split 8K-unaligned accesses Andrei Warkentin
2011-03-10 1:03 ` [RFC] MMC: Extends card quicks with MMC/SD quirks matching the CID Andrei Warkentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=HBwXQL125Zat-wAcZYFE5ZKy9bUzqBfp+sB_u@mail.gmail.com' \
--to=andreiw@motorola.com \
--cc=arnd@arndb.de \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).