linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kishore Kadiyala <kishorek.kadiyala@gmail.com>
To: akpm@linux-foundation.org
Cc: torvalds@linux-foundation.org, cjb@laptop.org,
	linux-mmc@vger.kernel.org, madhu.cr@ti.com
Subject: Re: [patch 149/177] drivers/mmc/host/omap_hsmmc.c: use resource_size()
Date: Wed, 23 Mar 2011 13:08:50 +0530	[thread overview]
Message-ID: <AANLkTikU3-WOmA9=TKv_2dFvB4zRvMR67Ro3aEW_ANuW@mail.gmail.com> (raw)
In-Reply-To: <201103222334.p2MNYhll002442@imap1.linux-foundation.org>

On Wed, Mar 23, 2011 at 5:04 AM,  <akpm@linux-foundation.org> wrote:
> From: Chris Ball <cjb@laptop.org>
>
> Use resource_size().
>
> Signed-off-by: Chris Ball <cjb@laptop.org>
> Cc: Madhusudhan Chikkature <madhu.cr@ti.com>
> Cc: <linux-mmc@vger.kernel.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

Feel free to add
Acked-by: Kishore Kadiyala <kishore.kadiyala@ti.com>

> ---
>
>  drivers/mmc/host/omap_hsmmc.c |    7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff -puN drivers/mmc/host/omap_hsmmc.c~drivers-mmc-host-omap_hsmmcc-use-resource_size drivers/mmc/host/omap_hsmmc.c
> --- a/drivers/mmc/host/omap_hsmmc.c~drivers-mmc-host-omap_hsmmcc-use-resource_size
> +++ a/drivers/mmc/host/omap_hsmmc.c
> @@ -2047,8 +2047,7 @@ static int __init omap_hsmmc_probe(struc
>
>        res->start += pdata->reg_offset;
>        res->end += pdata->reg_offset;
> -       res = request_mem_region(res->start, res->end - res->start + 1,
> -                                                       pdev->name);
> +       res = request_mem_region(res->start, resource_size(res), pdev->name);
>        if (res == NULL)
>                return -EBUSY;
>
> @@ -2287,7 +2286,7 @@ err1:
>  err_alloc:
>        omap_hsmmc_gpio_free(pdata);
>  err:
> -       release_mem_region(res->start, res->end - res->start + 1);
> +       release_mem_region(res->start, resource_size(res));
>        return ret;
>  }
>
> @@ -2324,7 +2323,7 @@ static int omap_hsmmc_remove(struct plat
>
>        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>        if (res)
> -               release_mem_region(res->start, res->end - res->start + 1);
> +               release_mem_region(res->start, resource_size(res));
>        platform_set_drvdata(pdev, NULL);
>
>        return 0;
> _
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

      reply	other threads:[~2011-03-23  7:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-22 23:34 [patch 149/177] drivers/mmc/host/omap_hsmmc.c: use resource_size() akpm
2011-03-23  7:38 ` Kishore Kadiyala [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTikU3-WOmA9=TKv_2dFvB4zRvMR67Ro3aEW_ANuW@mail.gmail.com' \
    --to=kishorek.kadiyala@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cjb@laptop.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=madhu.cr@ti.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).