From mboxrd@z Thu Jan 1 00:00:00 1970 From: Magnus Damm Subject: Re: [PATCH] tmio_mmc: Allow 2 byte requests in 4-bit mode Date: Sat, 21 Aug 2010 07:59:59 +0900 Message-ID: References: <4C4555DA.40203@renesas.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:53188 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750902Ab0HTXAA (ORCPT ); Fri, 20 Aug 2010 19:00:00 -0400 In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Ian Molton Cc: Yusuke Goda , damm@opensource.se, sameo@linux.intel.com, Paul Mundt , g.liakhovetski@gmx.de, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton On Tue, Jul 27, 2010 at 5:05 PM, Magnus Damm wrote: >> On 23 July 2010 12:05, Magnus Damm wrote: >>> 2010/7/20 Yusuke Goda : >>>> Adjust the tmio_mmc block size check to accept 2-byte requests in 4-bit mode. >>>> Tested with the SDHI hardware block included in sh7724. >>>> >>>> Signed-off-by: Yusuke Goda >>> >>> With this patch applied I can use SDIO cards in polling mode with the >>> tmio-mmc driver. Tested with the SDHI hardware block on sh7372 using >>> the b43 driver and BCM4318 hardware and the unfortunately out-of-tree >>> AR6002 "android" driver. >>> >>> Acked-by: Magnus Damm >>> > On Tue, Jul 27, 2010 at 4:57 PM, Ian Molton wrote: >> This change needs to be modified to test what hardware is present. >> this wont work on my hardware TTBOMK. > > Ok, just curious, on which platform did you test it? > > On SDHI hardware the 2-byte access works just fine in 4-bit mode. Hi Ian, Any update on this? I'd like to see this patch upstream since it unbreaks SDIO support for platforms with SDHI controllers. I have a BCM4318-based SDIO card that I can send with snail mail from Japan if anyone is interested in testing on non-SDHI platforms. Thanks, / magnus