From: Ian Molton <ian@mnementh.co.uk>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-sh@vger.kernel.org, linux-mmc@vger.kernel.org,
Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH 1/6] mmc: tmio: split core functionality, DMA and MFD glue
Date: Wed, 16 Mar 2011 11:09:46 +0000 [thread overview]
Message-ID: <AANLkTim_-MLJaWtnJN2jJjiXQdChfzi6yNkX8hSy8sgg@mail.gmail.com> (raw)
In-Reply-To: <AANLkTinDSfn-QTNdmU6gGnZ0fY0U-wnpbO3-aTxE3GBz@mail.gmail.com>
Im fine with it as long as it doesnt complicate my plan to add PXA DMA
to the driver.
--
Ian Molton
Linux, Automotive, and other hacking:
http://www.mnementh.co.uk/
On 15 March 2011 09:01, Magnus Damm <magnus.damm@gmail.com> wrote:
> On Mon, Mar 14, 2011 at 7:51 AM, Guennadi Liakhovetski
> <g.liakhovetski@gmx.de> wrote:
>> On Sun, 13 Mar 2011, Magnus Damm wrote:
>>> On Sun, Mar 13, 2011 at 7:48 AM, Guennadi Liakhovetski
>>> <g.liakhovetski@gmx.de> wrote:
>>> > On Sun, 13 Mar 2011, Magnus Damm wrote:
>>> >> On Fri, Mar 11, 2011 at 4:51 PM, Guennadi Liakhovetski
>>> >> <g.liakhovetski@gmx.de> wrote:
>>> >> > TMIO MMC chips contain an SD / SDIO IP core from Panasonic, similar to
>>> >> > the one, used in MN5774 and other MN57xx controllers. These IP cores are
>>> >> > included in many multifunction devices, in sh-mobile chips from Renesas,
>>> >> > in the latter case they can also use DMA. Some sh-mobile implementations
>>> >> > also have some other specialities, that MFD-based solutions don't have.
>>> >> > This makes supporting all these features in a monolithic driver inconveniet
>>> >> > and error-prone. This patch splits the driver into 3 parts: the core,
>>> >> > the MFD glue and the DMA support. In case of a modular build, two modules
>>> >> > will be built: mmc_tmio_core and mmc_tmio.
>>> >> >
>>> >> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>>> >> > ---
>
>>> What's the reason behind creating tmio_mmc_core.o instead of simply
>>> having tmio_mmc_pio.o + tmio_mmc_dma.o? That must be the most
>>> straightforward solution, no?
>>
>> You mean two kernel modules ..._pio.ko and ..._dma.ko? but why?... I don't
>> see any advantages in such a split, besides, they are calling into each
>> other ATM.
>
> Yeah, two kernel modules. That would be the cleanest IMO. But it's not
> such a big deal though, if you think this split is the best and
> everyone else is happy then I'm fine as well.
>
> Thanks,
>
> / magnus
>
next prev parent reply other threads:[~2011-03-16 11:10 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-11 7:51 [PATCH 0/6] mmc: split the tmio driver into several modules Guennadi Liakhovetski
2011-03-11 7:51 ` [PATCH 1/6] mmc: tmio: split core functionality, DMA and MFD glue Guennadi Liakhovetski
2011-03-12 16:05 ` Magnus Damm
2011-03-12 22:48 ` Guennadi Liakhovetski
2011-03-13 3:57 ` Magnus Damm
2011-03-13 22:51 ` Guennadi Liakhovetski
2011-03-15 9:01 ` Magnus Damm
2011-03-16 11:09 ` Ian Molton [this message]
2011-03-16 12:37 ` Magnus Damm
2011-03-21 11:19 ` Guennadi Liakhovetski
2011-03-11 7:52 ` [PATCH 2/6] sh: ecovec: use the CONFIG_MMC_TMIO symbols instead of MFD Guennadi Liakhovetski
2011-03-12 16:18 ` Magnus Damm
2011-03-12 23:00 ` Guennadi Liakhovetski
2011-03-11 7:52 ` [PATCH 3/6] mmc: tmio: convert the SDHI MMC driver from MFD to a standard platform driver Guennadi Liakhovetski
2011-03-13 4:14 ` Magnus Damm
2011-03-14 8:01 ` Guennadi Liakhovetski
2011-03-15 9:09 ` Magnus Damm
2011-03-11 7:52 ` [PATCH 4/6] ARM: mach-shmobile: convert boards to use linux/mmc/sh_mobile_sdhi.h Guennadi Liakhovetski
2011-03-11 7:52 ` [PATCH 5/6] sh: " Guennadi Liakhovetski
2011-03-11 7:52 ` [PATCH 6/6] mfd: remove now redundant sh_mobile_sdhi.h header Guennadi Liakhovetski
2011-03-15 21:25 ` [PATCH 0/6] mmc: split the tmio driver into several modules Ian Molton
2011-03-21 11:38 ` Guennadi Liakhovetski
2011-03-22 5:31 ` Simon Horman
2011-03-22 12:28 ` Paul Mundt
2011-03-22 22:06 ` Simon Horman
2011-03-23 14:54 ` Paul Mundt
2011-03-23 22:42 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTim_-MLJaWtnJN2jJjiXQdChfzi6yNkX8hSy8sgg@mail.gmail.com \
--to=ian@mnementh.co.uk \
--cc=cjb@laptop.org \
--cc=g.liakhovetski@gmx.de \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).