From: Grazvydas Ignotas <notasas@gmail.com>
To: Dmitry Shmidt <dimitrysh@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Kalle Valo <kalle.valo@iki.fi>,
linux-mmc@vger.kernel.org
Subject: Re: [PATCH] sdio: add new function for RAW (Read after Write) operation
Date: Sat, 15 May 2010 23:46:31 +0300 [thread overview]
Message-ID: <AANLkTimyIuNIUTnT5BVE_tJHGhwHMa8hBDd4yB4H-Zcu@mail.gmail.com> (raw)
In-Reply-To: <AANLkTin5TMVmq92bueC-0zZZbjcYM1MObLzPPY4ucq0h@mail.gmail.com>
On Sat, May 15, 2010 at 7:25 PM, Dmitry Shmidt <dimitrysh@google.com> wrote:
> Hi Grazvydas,
>
> You are right.
> mmc_io_rw_direct() implementation doesn't check R/W flag and returns
> data if "out" != NULL.
> So if SDIO spec "demands" WRITE flag and wl1251 ignores it anyway,
> then we should use WRITE.
> You function name is slightly confusing I would say, but I am fine
> with the patch.
I found it a bit hard to find a fitting name that would be similar to
other SDIO function names so I'm open to suggestions. Few other names:
sdio_read_after_write_b
sdio_rawb
Maybe our kernel veteran Andrew can suggest us something? :-)
next prev parent reply other threads:[~2010-05-15 20:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 21:18 [PATCH] sdio: add new function for RAW (Read after Write) operation Grazvydas Ignotas
2010-05-14 11:04 ` Grazvydas Ignotas
2010-05-14 22:06 ` Andrew Morton
2010-05-15 0:02 ` Dmitry Shmidt
2010-05-15 12:16 ` Grazvydas Ignotas
2010-05-15 16:25 ` Dmitry Shmidt
2010-05-15 20:46 ` Grazvydas Ignotas [this message]
2010-05-17 6:43 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimyIuNIUTnT5BVE_tJHGhwHMa8hBDd4yB4H-Zcu@mail.gmail.com \
--to=notasas@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dimitrysh@google.com \
--cc=kalle.valo@iki.fi \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).