From: Per Forlin <per.forlin@linaro.org>
To: Troy Kisky <troy.kisky@boundarydevices.com>
Cc: Per Forlin <per.forlin@stericsson.com>,
linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Nicolas Pitre <nicolas.pitre@linaro.org>,
linaro-dev@lists.linaro.org, Daniel Drake <dsd@laptop.org>,
Linus Walleij <linus.walleij@linaro.org>,
Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH v2 1/2] sdio: add quirk to handle pending IRQ in case of none CCCR_INTx bits
Date: Tue, 7 Jun 2011 08:49:48 +0200 [thread overview]
Message-ID: <BANLkTi=Dmntzb=4BBptwqZ5WfBMQYbaTGA@mail.gmail.com> (raw)
In-Reply-To: <4DE6B0E8.9050306@boundarydevices.com>
On 1 June 2011 23:36, Troy Kisky <troy.kisky@boundarydevices.com> wrote:
> On 6/1/2011 1:48 AM, Per Forlin wrote:
>> From: Per Forlin <per.forlin@linaro.org>
>
>> diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h
>> index 7b4fd7b..852021c 100644
>> --- a/include/linux/mmc/card.h
>> +++ b/include/linux/mmc/card.h
>> @@ -175,6 +175,7 @@ struct mmc_card {
>> #define MMC_QUIRK_DISABLE_CD (1<<5) /* disconnect CD/DAT[3] resistor */
>> #define MMC_QUIRK_INAND_CMD38 (1<<6) /* iNAND devices have broken CMD38 */
>> #define MMC_QUIRK_BLK_NO_CMD23 (1<<7) /* Avoid CMD23 for regular multiblock */
>> +#define MMC_QUIRK_SDIO_IRQ_CCCR_INTX_0 (1<<7) /* SDIO card has IRQ even if CCCR_INTx is 0 */
>
> Using the same value as MMC_QUIRK_BLK_NO_CMD23 looks odd...
>
Thanks for your observation.
Typo, it should be (1 << 8)
I'll update the patch but I don't plan post a new version yet. The
root cause issue in the libertas is resolved. If the fix turns out to
be needed later on I resend it.
Thanks,
Per
next prev parent reply other threads:[~2011-06-07 6:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 8:48 [PATCH v2 0/2] sdio: add quirk for spurious SDIO IRQ Per Forlin
[not found] ` <1306918113-23872-1-git-send-email-per.forlin-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
2011-06-01 8:48 ` [PATCH v2 1/2] sdio: add quirk to handle pending IRQ in case of none CCCR_INTx bits Per Forlin
2011-06-01 8:48 ` [PATCH v2 2/2] sdio: report error if pending IRQ but " Per Forlin
2011-06-01 21:36 ` [PATCH v2 1/2] sdio: add quirk to handle pending IRQ in case of " Troy Kisky
2011-06-07 6:49 ` Per Forlin [this message]
2011-06-01 15:59 ` [PATCH v2 0/2] sdio: add quirk for spurious SDIO IRQ Nicolas Pitre
2011-06-01 17:00 ` Chris Ball
2011-06-07 6:41 ` Per Forlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=Dmntzb=4BBptwqZ5WfBMQYbaTGA@mail.gmail.com' \
--to=per.forlin@linaro.org \
--cc=cjb@laptop.org \
--cc=dsd@laptop.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=nicolas.pitre@linaro.org \
--cc=per.forlin@stericsson.com \
--cc=troy.kisky@boundarydevices.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).