From: Andrei Warkentin <andreiw@motorola.com>
To: Chris Ball <cjb@laptop.org>
Cc: linux-mmc@vger.kernel.org
Subject: Re: SanDisk 4.3+ iNAND eMMC devices TRIM bug workaround.
Date: Tue, 12 Apr 2011 13:06:48 -0500 [thread overview]
Message-ID: <BANLkTi=N75ATcXHqbjDMpCMJ1bGnJggqog@mail.gmail.com> (raw)
In-Reply-To: <m34o631k6t.fsf@pullcord.laptop.org>
On Tue, Apr 12, 2011 at 11:57 AM, Chris Ball <cjb@laptop.org> wrote:
> Hi Andrei,
>
> On Mon, Apr 11 2011, Andrei Warkentin wrote:
>> This fixes the out-of-spec erase/trim support. CMD38 argument
>> is passed through an EXT_CSD byte instead of as the command
>> argument. This has the effect that trims act as group erases,
>> erasing more data than necessary. Secure trims/erases were also affected.
>>
>> N.B. This depends on the mmc_switch patch from the earlier boot partition
>> patchset (MMC: Allow setting CMD timeout for CMD6 (SWITCH)). This also
>> depends on the update core/quirks.c code.
>>
>> ToC:
>> [PATCH 1/2] MMC: Support for block quirks.
>> [PATCH 2/2] MMC: Fix erase/trim for certain SanDisk cards.
>
> Looks like these are missing your new timeout arg to mmc_switch():
>
> drivers/mmc/card/block.c: In function ‘mmc_blk_issue_discard_rq’:
> drivers/mmc/card/block.c:371:6: error: too few arguments to function ‘mmc_switch’
> include/linux/mmc/core.h:138:12: note: declared here
> drivers/mmc/card/block.c: In function ‘mmc_blk_issue_secdiscard_rq’:
> drivers/mmc/card/block.c:410:6: error: too few arguments to function ‘mmc_switch’
> include/linux/mmc/core.h:138:12: note: declared here
> drivers/mmc/card/block.c:419:7: error: too few arguments to function ‘mmc_switch’
>
> Thanks,
>
> - Chris.
> --
> Chris Ball <cjb@laptop.org> <http://printf.net/>
> One Laptop Per Child
>
I'm sorry about that. I was sure I had rebased it appropriately, but I
had not. I will repush it.
A
next prev parent reply other threads:[~2011-04-12 18:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-11 22:20 SanDisk 4.3+ iNAND eMMC devices TRIM bug workaround Andrei Warkentin
2011-04-11 22:20 ` [PATCH 1/2] MMC: Support for block quirks Andrei Warkentin
2011-04-11 22:20 ` [PATCH 2/2] MMC: Fix erase/trim for certain SanDisk cards Andrei Warkentin
2011-04-12 16:57 ` SanDisk 4.3+ iNAND eMMC devices TRIM bug workaround Chris Ball
2011-04-12 18:06 ` Andrei Warkentin [this message]
2011-04-12 20:03 ` [PATCH] MMC: Fix erase/trim for certain SanDisk cards Andrei Warkentin
2011-04-12 19:27 ` Andrei Warkentin
2011-04-12 19:33 ` Chris Ball
2011-04-12 19:30 ` Andrei Warkentin
2011-04-12 20:06 ` [PatchRebased] " Andrei Warkentin
2011-04-12 19:37 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTi=N75ATcXHqbjDMpCMJ1bGnJggqog@mail.gmail.com' \
--to=andreiw@motorola.com \
--cc=cjb@laptop.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).