From mboxrd@z Thu Jan 1 00:00:00 1970 From: Per Forlin Subject: Re: [PATCH] mmc: mxs-mmc: add support for pre_req and post_req Date: Wed, 20 Apr 2011 17:22:34 +0200 Message-ID: References: <1302116833-24540-1-git-send-email-per.forlin@linaro.org> <1303058010-30256-1-git-send-email-shawn.guo@linaro.org> <20110417164830.GE17935@S2100-06.ap.freescale.net> <20110420140120.GF1965@S2100-06.ap.freescale.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-qw0-f46.google.com ([209.85.216.46]:53778 "EHLO mail-qw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755159Ab1DTPWf convert rfc822-to-8bit (ORCPT ); Wed, 20 Apr 2011 11:22:35 -0400 Received: by qwk3 with SMTP id 3so410468qwk.19 for ; Wed, 20 Apr 2011 08:22:35 -0700 (PDT) In-Reply-To: <20110420140120.GF1965@S2100-06.ap.freescale.net> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Shawn Guo Cc: Shawn Guo , linaro-kernel@lists.linaro.org, linux-mmc@vger.kernel.org, cjb@laptop.org, linux-arm-kernel@lists.infradead.org, patches@linaro.org On 20 April 2011 16:01, Shawn Guo wrote: > On Wed, Apr 20, 2011 at 10:01:22AM +0200, Per Forlin wrote: >> On 17 April 2011 18:48, Shawn Guo wrote: >> > On Mon, Apr 18, 2011 at 12:33:30AM +0800, Shawn Guo wrote: >> >> pre_req() runs dma_map_sg() post_req() runs dma_unmap_sg. >> >> If not calling pre_req() before mxs_mmc_request(), request() >> >> will prepare the cache just like it did it before. >> >> It is optional to use pre_req() and post_req(). >> >> >> >> Signed-off-by: Shawn Guo >> >> --- >> >> =A0drivers/mmc/host/mxs-mmc.c | =A0 75 ++++++++++++++++++++++++++= ++++++++++++++++-- >> >> =A01 files changed, 72 insertions(+), 3 deletions(-) >> >> >> > >> > Here is the result of mmc_test case 37 ~ 40, which are designed to= see >> > the performance improvement introduced by non-blocking changes. >> > >> > Honestly, the improvement is not so impressive. =A0Not sure if the= patch >> > for mxs-mmc pre_req and post_req support was correctly produced. =A0= So >> > please help review ... >> My guess is that dma_unmap is not run in parallel with transfer. >> Please look at my patch reply. >> > Got it fixed in v2 posted just now. =A0Please take another look. > Unfortunately, I do not see noticeable difference than v1 in terms > of mmc_test result. > > Do you have omap_hsmmc and mmci mmc_test result data to share? > I keep the here: https://wiki.linaro.org/WorkingGroups/Kernel/Specs/StoragePerfMMC-async= -req > -- > Regards, > Shawn > > /Per