From: Per Forlin <per.forlin@linaro.org>
To: Lin Tony-B19295 <B19295@freescale.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linaro-dev@lists.linaro.org" <linaro-dev@lists.linaro.org>,
Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH v2 03/12] mmc: mmc_test: add test for none blocking transfers
Date: Wed, 20 Apr 2011 09:30:16 +0200 [thread overview]
Message-ID: <BANLkTik126o7w0+97iLL4p51h=0M-26dDg@mail.gmail.com> (raw)
In-Reply-To: <97D3A72708D04647A5AC84A04996E5B5125FB8@039-SN1MPN1-006.039d.mgd.msft.net>
On 17 April 2011 09:09, Lin Tony-B19295 <B19295@freescale.com> wrote:
> Hi Per
>
> Just have a glance of your patch, good thinking. But I have a question about this patch. You modified mmc_test to test your driver. Does it mean your driver's performance enhancement depends on application?
I added those tests in mmc_test to compare the performance between
blocking and none blocking. Basically it tests performance gain if
running dma_map and dma_unmap in parallel with the transfer, compared
to running dma_map and dma_unmap in serial with the transfer.
> The caller must have to know the next request so that could make driver prepare next during current transfer?
mmc_test tests the ideal performance gain (all request are linked together).
> So testing your driver with blocking request & non blocking request will have different throughput due to different application mechanism.
Yes.
I added support for mmc non blocking in the mmc block device but the
performance gain here depends on how the FS-requests are propagated
down to the mmc block device. If the request are added one by one,
waiting for the last request to complete before adding the new
request, there will be no performance gain.
To test the mmc block performance I have run IOZone in user space.
> Thanks
>
> BR
> Tony
BR
Per
next prev parent reply other threads:[~2011-04-20 7:30 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 19:07 [PATCH v2 00/12] mmc: use nonblock mmc requests to minimize latency Per Forlin
2011-04-06 19:07 ` [PATCH v2 01/12] mmc: add none blocking mmc request function Per Forlin
2011-04-15 10:34 ` David Vrabel
2011-04-20 7:17 ` Per Forlin
2011-04-26 13:29 ` David Vrabel
[not found] ` <4DB6C89F.10903-kQvG35nSl+M@public.gmane.org>
2011-04-26 14:22 ` Per Forlin
[not found] ` <1302116833-24540-1-git-send-email-per.forlin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-04-06 19:07 ` [PATCH v2 02/12] mmc: mmc_test: add debugfs file to list all tests Per Forlin
2011-04-06 19:07 ` [PATCH v2 03/12] mmc: mmc_test: add test for none blocking transfers Per Forlin
2011-04-17 7:09 ` Lin Tony-B19295
2011-04-20 7:30 ` Per Forlin [this message]
[not found] ` <1302116833-24540-4-git-send-email-per.forlin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2011-04-17 15:46 ` Shawn Guo
2011-04-20 7:41 ` Per Forlin
2011-04-06 19:07 ` [PATCH v2 04/12] mmc: add member in mmc queue struct to hold request data Per Forlin
2011-04-06 19:07 ` [PATCH v2 05/12] mmc: add a block request prepare function Per Forlin
2011-04-06 19:07 ` [PATCH v2 06/12] mmc: move error code in mmc_block_issue_rw_rq to a separate function Per Forlin
2011-04-06 19:07 ` [PATCH v2 07/12] mmc: add a second mmc queue request member Per Forlin
2011-04-06 19:07 ` [PATCH v2 08/12] mmc: add handling for two parallel block requests in issue_rw_rq Per Forlin
2011-04-20 11:32 ` Per Forlin
2011-04-06 19:07 ` [PATCH v2 09/12] mmc: test: add random fault injection in core.c Per Forlin
2011-04-06 19:07 ` [PATCH v2 10/12] omap_hsmmc: use original sg_len for dma_unmap_sg Per Forlin
2011-04-06 19:07 ` [PATCH v2 11/12] omap_hsmmc: add support for pre_req and post_req Per Forlin
2011-04-06 19:07 ` [PATCH v2 12/12] mmci: implement pre_req() and post_req() Per Forlin
2011-04-08 16:49 ` [PATCH v2 00/12] mmc: use nonblock mmc requests to minimize latency Linus Walleij
2011-04-09 11:55 ` Jae hoon Chung
[not found] ` <BANLkTikVeXvfSBS-xLDXVdesKJpKdtUVqg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-10 3:33 ` anish singh
2011-04-11 9:03 ` Per Forlin
[not found] ` <BANLkTikoj6UTx08ntZaMM15taKRXjrU_Mg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2011-04-11 9:07 ` Sachin Nikam
2011-04-11 9:08 ` Per Forlin
2011-04-19 14:30 ` Jae hoon Chung
2011-04-16 15:48 ` Shawn Guo
2011-04-20 8:19 ` Per Forlin
2011-04-16 16:48 ` [PATCH] mmc: sdhci: add support for pre_req and post_req Shawn Guo
2011-04-16 23:06 ` Andrei Warkentin
2011-04-22 11:01 ` Jaehoon Chung
2011-04-27 0:59 ` Andrei Warkentin
2011-04-26 1:26 ` Jaehoon Chung
2011-04-26 2:47 ` Shawn Guo
2011-04-26 10:21 ` Per Forlin
2011-04-17 16:33 ` [PATCH] mmc: mxs-mmc: " Shawn Guo
2011-04-17 16:48 ` Shawn Guo
2011-04-20 8:01 ` Per Forlin
2011-04-20 14:01 ` Shawn Guo
2011-04-20 15:22 ` Per Forlin
2011-04-21 6:25 ` Shawn Guo
2011-04-21 8:52 ` Per Forlin
2011-04-20 15:30 ` Per Forlin
2011-04-21 6:29 ` Shawn Guo
2011-04-21 8:46 ` Per Forlin
2011-04-21 9:11 ` Shawn Guo
2011-04-21 9:47 ` Per Forlin
2011-04-21 10:15 ` Per Forlin
2011-04-28 7:52 ` Per Forlin
2011-04-28 10:10 ` Russell King - ARM Linux
2011-04-20 7:58 ` Per Forlin
2011-04-20 8:17 ` Shawn Guo
2011-04-20 13:51 ` [PATCH v2] " Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTik126o7w0+97iLL4p51h=0M-26dDg@mail.gmail.com' \
--to=per.forlin@linaro.org \
--cc=B19295@freescale.com \
--cc=cjb@laptop.org \
--cc=linaro-dev@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).