Re: [PATCH] mmc: sdhci: fixed regulator control when suspend/resume

[Jae hoon Chung <jh80.chung@gmail.com>]

Hi, Wolfram..

2011/4/9 Wolfram Sang <w.sang@pengutronix.de>:
> On Thu, Apr 07, 2011 at 01:23:52PM +0900, Jaehoon Chung wrote:
>> Suspend/resume is working always enable regulator after resuming.
>> (if there is host->vmmc)
>
> The regulator is enabled during add_host. How could it not be enabled in
> suspend?

you're right..When running add_host, enabled the regulator "vmmc".
I'm missing this patch.sorry ^^
Actually,If controller didn't detect the card, i added disable
function in sdhci-s3c.c.
Then regulator is disabled when enter suspend. :)

But i didn't find methed to disable in sdhci.c.
(i think that should be find to use CDn pin)

I'll resend the modified patch.
If you have other method, let me know your opinion.

Thanks very much for your comment.
>
>>       struct regulator *vmmc; /* Power regulator */
>> +     bool restore_vmmc;      /* Restore vmmc */
>
> If you can explain the above, this should be turned into a SDHCI_-flag IMHO.
>
> Regards,
>
>   Wolfram
>
> --
> Pengutronix e.K.                           | Wolfram Sang                |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAk2fWC4ACgkQD27XaX1/VRuTAwCghHV5u2l8tAqnLPAwBf3fz+iV
> MVoAnRB+hXXCZU3xZQghwVVBcm7iu5+H
> =cDOF
> -----END PGP SIGNATURE-----
>
>