From: Andrei Warkentin <andreiw@motorola.com>
To: "Nath, Arindam" <Arindam.Nath@amd.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH v3 01/12] mmc: sdhci: add support for auto CMD23
Date: Sat, 16 Apr 2011 04:07:59 -0500 [thread overview]
Message-ID: <BANLkTimUrvnkg5dxiSh6cmToR_QTpYtnyw@mail.gmail.com> (raw)
In-Reply-To: <6C03668EAF45B747AF947A1603D1B300EB44434B@SAUSEXMBP01.amd.com>
On Sat, Apr 16, 2011 at 12:25 AM, Nath, Arindam <Arindam.Nath@amd.com> wrote:
> Hi Andrei,
>
> I saw in one of the community threads that you also have a patch ready for supporting Auto CMD23 for SDHCI. Can you share the same with us? I would like to take a look at your patch first before deciding whether it would make sense for controllers which comply with Host Controller Spec v3.00.
>
Will send updated patch set in a few. You and Subhash are on the Cc.
Once again, the Auto-CMD23 is completely untested. I would be
extremely grateful if you can verify it.
Is there any kind of error injection mechanism you guys use to verify
the error paths for Auto 12/23?
By the way -
+ /* If the host can perform ADMA operation, we reset SDMA flag */
+ if (host->flags & SDHCI_USE_ADMA)
+ host->flags &= ~SDHCI_USE_SDMA;
This seems completely unnecessary, as the code already prefers ADMA to
SDMA. What do you think?
A
next prev parent reply other threads:[~2011-04-16 9:08 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 10:38 [PATCH v3 00/12] add support for host controller v3.00 Arindam Nath
2011-04-15 10:38 ` [PATCH v3 01/12] mmc: sdhci: add support for auto CMD23 Arindam Nath
[not found] ` <BANLkTimZGonC+D0czjiY4i7pFFW=upj_qw@mail.gmail.com>
[not found] ` <6C03668EAF45B747AF947A1603D1B300EB443FB6@SAUSEXMBP01.amd.com>
[not found] ` <BANLkTimEKQceSiuL=dX2yhMw+MLu7BzLvQ@mail.gmail.com>
[not found] ` <BANLkTimfQo7wJ3_ecs64VSp7xKJrjYdJ3w@mail.gmail.com>
2011-04-15 20:04 ` Andrei Warkentin
2011-04-16 5:25 ` Nath, Arindam
2011-04-16 9:07 ` Andrei Warkentin [this message]
2011-04-16 9:40 ` Nath, Arindam
2011-04-16 10:04 ` Andrei Warkentin
2011-04-16 6:17 ` Subhash Jadavani
2011-04-16 6:25 ` Nath, Arindam
2011-04-16 6:37 ` Subhash Jadavani
2011-04-16 6:43 ` Nath, Arindam
2011-04-16 8:20 ` Andrei Warkentin
2011-04-16 8:17 ` Andrei Warkentin
2011-04-15 10:38 ` [PATCH v3 02/12] mmc: sd: add support for signal voltage switch procedure Arindam Nath
2011-04-15 10:38 ` [PATCH v3 03/12] mmc: sd: query function modes for uhs cards Arindam Nath
2011-04-15 10:38 ` [PATCH v3 04/12] mmc: sd: add support for driver type selection Arindam Nath
2011-04-15 10:38 ` [PATCH v3 05/12] mmc: sdhci: reset sdclk before setting high speed enable Arindam Nath
2011-04-15 10:38 ` [PATCH v3 06/12] mmc: sd: add support for uhs bus speed mode selection Arindam Nath
2011-04-15 10:38 ` [PATCH v3 07/12] mmc: sd: set current limit for uhs cards Arindam Nath
2011-04-15 14:06 ` [PATCH v3 00/12] add support for host controller v3.00 Chris Ball
2011-04-15 14:06 ` Nath, Arindam
2011-04-26 5:52 ` Nath, Arindam
2011-04-26 12:50 ` Chris Ball
2011-04-26 13:02 ` Wolfram Sang
2011-04-26 13:19 ` Chris Ball
2011-04-26 15:30 ` Philip Rakity
2011-04-26 15:41 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimUrvnkg5dxiSh6cmToR_QTpYtnyw@mail.gmail.com \
--to=andreiw@motorola.com \
--cc=Arindam.Nath@amd.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).