From: Andrei Warkentin <andreiw@motorola.com>
To: "Nath, Arindam" <Arindam.Nath@amd.com>
Cc: Subhash Jadavani <subhashj@codeaurora.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH v3 01/12] mmc: sdhci: add support for auto CMD23
Date: Sat, 16 Apr 2011 03:20:49 -0500 [thread overview]
Message-ID: <BANLkTimVQwbDt9OSe63miCwsErt=wKQKCA@mail.gmail.com> (raw)
In-Reply-To: <6C03668EAF45B747AF947A1603D1B300EB444355@SAUSEXMBP01.amd.com>
On Sat, Apr 16, 2011 at 1:43 AM, Nath, Arindam <Arindam.Nath@amd.com> wrote:
>> and
>> then sending the CMD23 for multi block read/write. MMC cards also
>> supports
>> CMD23 so in that case again you have to check MMC EXT_CSD register for
>> CMD23
>
> Yes, you are right. I followed the Physical Layer Spec v3.01 as is, so in case the support is needed for MMC cards, we will need to take care of that too.
It's already done. In the block layer. All you need to do is honor
mmc_request->sbc and set Auto-CMD23 and the CMD23 argument.
>> support. All this logic is better be in core/block layer and let
>> core/block
>> layer inform host controller when to send CMD23 and when not to.
>
> Well in that case, Auto CMD23 will never make sense.
I am unsure why you think that. All Auto CMD23 means is that instead
of manually sending CMD23 (and incurring the extra interrupt penalty),
I have the host automatically do it. But this feature should only be
enabled when upper layers care to enabled it. This is what the CMD23
support plumbed in.
A
next prev parent reply other threads:[~2011-04-16 8:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-15 10:38 [PATCH v3 00/12] add support for host controller v3.00 Arindam Nath
2011-04-15 10:38 ` [PATCH v3 01/12] mmc: sdhci: add support for auto CMD23 Arindam Nath
[not found] ` <BANLkTimZGonC+D0czjiY4i7pFFW=upj_qw@mail.gmail.com>
[not found] ` <6C03668EAF45B747AF947A1603D1B300EB443FB6@SAUSEXMBP01.amd.com>
[not found] ` <BANLkTimEKQceSiuL=dX2yhMw+MLu7BzLvQ@mail.gmail.com>
[not found] ` <BANLkTimfQo7wJ3_ecs64VSp7xKJrjYdJ3w@mail.gmail.com>
2011-04-15 20:04 ` Andrei Warkentin
2011-04-16 5:25 ` Nath, Arindam
2011-04-16 9:07 ` Andrei Warkentin
2011-04-16 9:40 ` Nath, Arindam
2011-04-16 10:04 ` Andrei Warkentin
2011-04-16 6:17 ` Subhash Jadavani
2011-04-16 6:25 ` Nath, Arindam
2011-04-16 6:37 ` Subhash Jadavani
2011-04-16 6:43 ` Nath, Arindam
2011-04-16 8:20 ` Andrei Warkentin [this message]
2011-04-16 8:17 ` Andrei Warkentin
2011-04-15 10:38 ` [PATCH v3 02/12] mmc: sd: add support for signal voltage switch procedure Arindam Nath
2011-04-15 10:38 ` [PATCH v3 03/12] mmc: sd: query function modes for uhs cards Arindam Nath
2011-04-15 10:38 ` [PATCH v3 04/12] mmc: sd: add support for driver type selection Arindam Nath
2011-04-15 10:38 ` [PATCH v3 05/12] mmc: sdhci: reset sdclk before setting high speed enable Arindam Nath
2011-04-15 10:38 ` [PATCH v3 06/12] mmc: sd: add support for uhs bus speed mode selection Arindam Nath
2011-04-15 10:38 ` [PATCH v3 07/12] mmc: sd: set current limit for uhs cards Arindam Nath
2011-04-15 14:06 ` [PATCH v3 00/12] add support for host controller v3.00 Chris Ball
2011-04-15 14:06 ` Nath, Arindam
2011-04-26 5:52 ` Nath, Arindam
2011-04-26 12:50 ` Chris Ball
2011-04-26 13:02 ` Wolfram Sang
2011-04-26 13:19 ` Chris Ball
2011-04-26 15:30 ` Philip Rakity
2011-04-26 15:41 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='BANLkTimVQwbDt9OSe63miCwsErt=wKQKCA@mail.gmail.com' \
--to=andreiw@motorola.com \
--cc=Arindam.Nath@amd.com \
--cc=linux-mmc@vger.kernel.org \
--cc=subhashj@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).