From: Andrei Warkentin <andreiw@motorola.com>
To: John Calixto <john.calixto@modsystems.com>
Cc: linux-mmc@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Chris Ball <cjb@laptop.org>
Subject: Re: [PATCH 1/4] MMC: Rename erase_timeout to cmd_timeout.
Date: Mon, 11 Apr 2011 15:34:58 -0500 [thread overview]
Message-ID: <BANLkTimnmVi6evmXqftCBFkGOKte5sQEdQ@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1104111213230.32082@peruna>
On Mon, Apr 11, 2011 at 2:18 PM, John Calixto
<john.calixto@modsystems.com> wrote:
> Hi Andrei,
>
> On Tue, 5 Apr 2011, Andrei Warkentin wrote:
>> diff --git a/include/linux/mmc/core.h b/include/linux/mmc/core.h
>> index 07f27af..a7d7da7 100644
>> --- a/include/linux/mmc/core.h
>> +++ b/include/linux/mmc/core.h
>> @@ -92,7 +92,7 @@ struct mmc_command {
>> * actively failing requests
>> */
>>
>> - unsigned int erase_timeout; /* in milliseconds */
>> + unsigned int cmd_timeout; /* in milliseconds */
>>
>> struct mmc_data *data; /* data segment associated with cmd */
>> struct mmc_request *mrq; /* associated request */
>
> Could you rename this field to "cmd_timeout_ms"? When I was testing the
> addition of cmd_timeout to my ioctl patch, I noticed that data timeout
> was being specified in ns and I had to scale cmd_timeout appropriately.
>
Yes! Absolutely. Just sent the updated patch set.
A
next prev parent reply other threads:[~2011-04-11 20:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-06 1:09 Boot partition support patch set Andrei Warkentin
2011-04-06 1:09 ` [PATCH 1/4] MMC: Rename erase_timeout to cmd_timeout Andrei Warkentin
2011-04-11 19:18 ` John Calixto
2011-04-11 20:34 ` Andrei Warkentin [this message]
2011-04-06 1:09 ` [PATCH 2/4] MMC: SDHCI R1B command handling + MMC_CAP_ERASE Andrei Warkentin
2011-04-06 1:09 ` [PATCH 3/4] MMC: Allow setting CMD timeout for CMD6 (SWITCH) Andrei Warkentin
2011-04-06 1:09 ` [PATCH 4/4] MMC: MMC boot partitions support Andrei Warkentin
2011-04-06 23:20 ` Boot partition support patch set Andrei Warkentin
2011-04-07 21:23 ` Chris Ball
2011-04-08 3:47 ` Arnd Bergmann
2011-04-08 6:58 ` Andrei Warkentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTimnmVi6evmXqftCBFkGOKte5sQEdQ@mail.gmail.com \
--to=andreiw@motorola.com \
--cc=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=john.calixto@modsystems.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).