From: zhangfei gao <zhangfei.gao@gmail.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: linux-mmc@vger.kernel.org, Daniel Drake <dsd@laptop.org>,
Bing Zhao <bzhao@marvell.com>
Subject: Re: [PATCH] mmc: sdio: reset card during power_restore
Date: Wed, 29 Jun 2011 17:19:14 +0800 [thread overview]
Message-ID: <BANLkTinpAc0GeB1Lccg6f-R54qXN9Rq0Uw@mail.gmail.com> (raw)
In-Reply-To: <BANLkTinAPGWH-hZiqc8zWA_Mifa_TPk3OA@mail.gmail.com>
On Wed, Jun 29, 2011 at 4:57 PM, Ohad Ben-Cohen <ohad@wizery.com> wrote:
> On Wed, Jun 29, 2011 at 11:43 AM, zhangfei gao <zhangfei.gao@gmail.com> wrote:
>> However still not fully understand how to call ->remove to power off
>> wlan, using suspend system looks to me is only test method, which
>> counting on bus_ops->suspend returns -ENOSYS.
>
> Please take a look at mac80211 and wl12xx.
>
> We're not using ->remove, ->probe or -ENOSYS at all.
>
> When the user brings up the interface, we then power up the chip and
> download the firmware.
> Likewise, when the interface is brought down, we just power off the chip.
Thanks a lot Ohad & Daniel :)
Enable wlan: # ifconfig up mlan0 -> power up the chip via runtime PM
-> wlan_probe download the firmware
Disable wlan: # ifconfig down mlan0 -> power down the chip via runtime
PM -> wlan_remove ?
So every time ifconfig up/down, the chip is power up/down, and
firmware reloaded?
Is this understand correct?
Then runtime pm should also integrated into wlan driver as well.
next prev parent reply other threads:[~2011-06-29 9:19 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-05 12:38 [PATCH] mmc: sdio: reset card during power_restore Daniel Drake
2011-06-05 13:48 ` Ohad Ben-Cohen
2011-06-07 16:41 ` Daniel Drake
2011-06-07 20:52 ` Ohad Ben-Cohen
2011-06-08 9:20 ` Daniel Drake
2011-06-08 9:33 ` Ohad Ben-Cohen
2011-06-08 13:36 ` Daniel Drake
2011-06-08 14:02 ` Ohad Ben-Cohen
2011-06-08 14:21 ` Daniel Drake
2011-06-08 20:05 ` Ohad Ben-Cohen
2011-06-08 20:58 ` Daniel Drake
2011-06-09 3:23 ` Ohad Ben-Cohen
2011-06-09 15:51 ` Daniel Drake
2011-06-09 15:59 ` Ohad Ben-Cohen
2011-06-09 16:21 ` Daniel Drake
2011-06-09 16:30 ` Ohad Ben-Cohen
2011-06-09 16:44 ` Daniel Drake
2011-06-09 17:27 ` Ohad Ben-Cohen
2011-06-09 17:56 ` Daniel Drake
2011-06-09 18:25 ` Ohad Ben-Cohen
2011-06-09 19:55 ` Daniel Drake
2011-06-09 23:27 ` Ohad Ben-Cohen
2011-06-10 16:15 ` Daniel Drake
2011-06-13 19:52 ` Ohad Ben-Cohen
2011-06-16 17:27 ` Daniel Drake
2011-06-16 19:03 ` Philip Rakity
2011-06-16 21:22 ` Ohad Ben-Cohen
2011-06-17 13:58 ` Daniel Drake
2011-06-17 14:31 ` Ohad Ben-Cohen
2011-06-17 15:19 ` Daniel Drake
2011-06-19 10:33 ` Daniel Drake
2011-06-19 11:00 ` Ohad Ben-Cohen
2011-06-25 18:23 ` Daniel Drake
2011-06-27 20:26 ` Ohad Ben-Cohen
2011-06-28 9:13 ` zhangfei gao
2011-06-28 11:10 ` Ohad Ben-Cohen
2011-06-29 8:43 ` zhangfei gao
2011-06-29 8:57 ` Ohad Ben-Cohen
2011-06-29 9:19 ` zhangfei gao [this message]
2011-06-29 15:25 ` Ohad Ben-Cohen
2011-06-29 8:56 ` Daniel Drake
2011-06-07 21:01 ` Ohad Ben-Cohen
-- strict thread matches above, loose matches on Subject: below --
2011-06-25 18:20 Daniel Drake
2011-06-26 12:33 ` Ohad Ben-Cohen
2011-06-26 15:23 ` Chris Ball
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BANLkTinpAc0GeB1Lccg6f-R54qXN9Rq0Uw@mail.gmail.com \
--to=zhangfei.gao@gmail.com \
--cc=bzhao@marvell.com \
--cc=dsd@laptop.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox