[PATCH 0/2] mmc: tmio: Remove obsolete callbacks

[PATCH 0/2] mmc: tmio: Remove obsolete callbacks

[Geert Uytterhoeven]

	Hi all,

This patch series removes two unused callbacks from the tmio_mmc_data
structure, and related infrastructure code.
  - The first patch touches only the MFD subsystem.
  - The second patch touches both the MMC and MFD subsystems, and has a
    contextual dependency on the first patch.  If really needed, it can
    be split in an MMC and MFD part, but the MFD part depends on the MMC
    part anyway.

Thanks for your comments!

Geert Uytterhoeven (2):
  mfd: tmio: Remove obsolete .set_clk_div() callback
  mmc: tmio: Remove obsolete .set_pwr() callback()

 drivers/mmc/host/tmio_mmc.h      | 3 ---
 drivers/mmc/host/tmio_mmc_core.c | 8 --------
 include/linux/mfd/tmio.h         | 2 --
 3 files changed, 13 deletions(-)

-- 
2.34.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

[PATCH 1/2] mfd: tmio: Remove obsolete .set_clk_div() callback

[Geert Uytterhoeven]

Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last
user of the .set_clk_div() callback in the tmio_mmc_data structure.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 include/linux/mfd/tmio.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
index eace8ea6cda05a3d..aca74ac1ff69e6f7 100644
--- a/include/linux/mfd/tmio.h
+++ b/include/linux/mfd/tmio.h
@@ -101,7 +101,6 @@ struct tmio_mmc_data {
 	unsigned int			max_blk_count;
 	unsigned short			max_segs;
 	void (*set_pwr)(struct platform_device *host, int state);
-	void (*set_clk_div)(struct platform_device *host, int state);
 };
 
 /*
-- 
2.34.1

[PATCH 2/2] mmc: tmio: Remove obsolete .set_pwr() callback()

[Geert Uytterhoeven]

Commit ca78476e4888f1f1 ("mfd: Remove toshiba tmio drivers") removed the
last users of the .set_pwr() callback in the tmio_mmc_data structure.
Remove the callback, and all related infrastructure.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Laurent tried this before in commit 3af9d15c719017fe
("mmc: tmio-mmc: Remove .set_pwr() callback from platform data"),
but it had to be reverted in commit 9d731e7539713acc ("Revert
"mmc: tmio-mmc: Remove .set_pwr() callback from platform data"")
because there were still users at that time.
---
 drivers/mmc/host/tmio_mmc.h      | 3 ---
 drivers/mmc/host/tmio_mmc_core.c | 8 --------
 include/linux/mfd/tmio.h         | 1 -
 3 files changed, 12 deletions(-)

diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h
index de56e6534aeaaa10..2af5730c21f4a98d 100644
--- a/drivers/mmc/host/tmio_mmc.h
+++ b/drivers/mmc/host/tmio_mmc.h
@@ -139,9 +139,6 @@ struct tmio_mmc_host {
 	struct mmc_host         *mmc;
 	struct mmc_host_ops     ops;
 
-	/* Callbacks for clock / power control */
-	void (*set_pwr)(struct platform_device *host, int state);
-
 	/* pio related stuff */
 	struct scatterlist      *sg_ptr;
 	struct scatterlist      *sg_orig;
diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c
index 93e912afd3ae5aa0..7b4256f0cbe77028 100644
--- a/drivers/mmc/host/tmio_mmc_core.c
+++ b/drivers/mmc/host/tmio_mmc_core.c
@@ -880,9 +880,6 @@ static void tmio_mmc_power_on(struct tmio_mmc_host *host, unsigned short vdd)
 
 	/* .set_ios() is returning void, so, no chance to report an error */
 
-	if (host->set_pwr)
-		host->set_pwr(host->pdev, 1);
-
 	if (!IS_ERR(mmc->supply.vmmc)) {
 		ret = mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, vdd);
 		/*
@@ -916,9 +913,6 @@ static void tmio_mmc_power_off(struct tmio_mmc_host *host)
 
 	if (!IS_ERR(mmc->supply.vmmc))
 		mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, 0);
-
-	if (host->set_pwr)
-		host->set_pwr(host->pdev, 0);
 }
 
 static unsigned int tmio_mmc_get_timeout_cycles(struct tmio_mmc_host *host)
@@ -1160,8 +1154,6 @@ int tmio_mmc_host_probe(struct tmio_mmc_host *_host)
 	if (pdata->flags & TMIO_MMC_USE_BUSY_TIMEOUT && !_host->get_timeout_cycles)
 		_host->get_timeout_cycles = tmio_mmc_get_timeout_cycles;
 
-	_host->set_pwr = pdata->set_pwr;
-
 	ret = tmio_mmc_init_ocr(_host);
 	if (ret < 0)
 		return ret;
diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
index aca74ac1ff69e6f7..8c09d14a3a286ca0 100644
--- a/include/linux/mfd/tmio.h
+++ b/include/linux/mfd/tmio.h
@@ -100,7 +100,6 @@ struct tmio_mmc_data {
 	dma_addr_t			dma_rx_offset;
 	unsigned int			max_blk_count;
 	unsigned short			max_segs;
-	void (*set_pwr)(struct platform_device *host, int state);
 };
 
 /*
-- 
2.34.1

Re: [PATCH 2/2] mmc: tmio: Remove obsolete .set_pwr() callback()

[Lee Jones]

On Thu, 20 Jun 2024, Geert Uytterhoeven wrote:

> Commit ca78476e4888f1f1 ("mfd: Remove toshiba tmio drivers") removed the
> last users of the .set_pwr() callback in the tmio_mmc_data structure.
> Remove the callback, and all related infrastructure.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Laurent tried this before in commit 3af9d15c719017fe
> ("mmc: tmio-mmc: Remove .set_pwr() callback from platform data"),
> but it had to be reverted in commit 9d731e7539713acc ("Revert
> "mmc: tmio-mmc: Remove .set_pwr() callback from platform data"")
> because there were still users at that time.
> ---
>  drivers/mmc/host/tmio_mmc.h      | 3 ---
>  drivers/mmc/host/tmio_mmc_core.c | 8 --------
>  include/linux/mfd/tmio.h         | 1 -

Acked-by: Lee Jones <lee@kernel.org>

-- 
Lee Jones [李琼斯]

Re: [PATCH 1/2] mfd: tmio: Remove obsolete .set_clk_div() callback

[Lee Jones]

On Thu, 20 Jun 2024, Geert Uytterhoeven wrote:

> Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last
> user of the .set_clk_div() callback in the tmio_mmc_data structure.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  include/linux/mfd/tmio.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
> index eace8ea6cda05a3d..aca74ac1ff69e6f7 100644
> --- a/include/linux/mfd/tmio.h
> +++ b/include/linux/mfd/tmio.h
> @@ -101,7 +101,6 @@ struct tmio_mmc_data {
>  	unsigned int			max_blk_count;
>  	unsigned short			max_segs;
>  	void (*set_pwr)(struct platform_device *host, int state);
> -	void (*set_clk_div)(struct platform_device *host, int state);

Any ramifications for just hoovering this up?

-- 
Lee Jones [李琼斯]

Re: [PATCH 1/2] mfd: tmio: Remove obsolete .set_clk_div() callback

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

On Thu, Jun 20, 2024 at 05:39:45PM GMT, Geert Uytterhoeven wrote:
> Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last
> user of the .set_clk_div() callback in the tmio_mmc_data structure.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 2/2] mmc: tmio: Remove obsolete .set_pwr() callback()

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

On Thu, Jun 20, 2024 at 05:39:46PM GMT, Geert Uytterhoeven wrote:
> Commit ca78476e4888f1f1 ("mfd: Remove toshiba tmio drivers") removed the
> last users of the .set_pwr() callback in the tmio_mmc_data structure.
> Remove the callback, and all related infrastructure.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Cool, I had the gut feeling that more cleanups were possible after the
plain TMIO drivers were removed.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 2/2] mmc: tmio: Remove obsolete .set_pwr() callback()

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 553 bytes --]

On Thu, Jun 20, 2024 at 10:09:28PM GMT, Wolfram Sang wrote:
> On Thu, Jun 20, 2024 at 05:39:46PM GMT, Geert Uytterhoeven wrote:
> > Commit ca78476e4888f1f1 ("mfd: Remove toshiba tmio drivers") removed the
> > last users of the .set_pwr() callback in the tmio_mmc_data structure.
> > Remove the callback, and all related infrastructure.
> > 
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Also:

Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 1/2] mfd: tmio: Remove obsolete .set_clk_div() callback

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

On Thu, Jun 20, 2024 at 10:05:44PM GMT, Wolfram Sang wrote:
> On Thu, Jun 20, 2024 at 05:39:45PM GMT, Geert Uytterhoeven wrote:
> > Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last
> > user of the .set_clk_div() callback in the tmio_mmc_data structure.
> > 
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Also:

Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH 1/2] mfd: tmio: Remove obsolete .set_clk_div() callback

[Lad, Prabhakar]

On Thu, Jun 20, 2024 at 4:40 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last
> user of the .set_clk_div() callback in the tmio_mmc_data structure.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  include/linux/mfd/tmio.h | 1 -
>  1 file changed, 1 deletion(-)
>

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
> index eace8ea6cda05a3d..aca74ac1ff69e6f7 100644
> --- a/include/linux/mfd/tmio.h
> +++ b/include/linux/mfd/tmio.h
> @@ -101,7 +101,6 @@ struct tmio_mmc_data {
>         unsigned int                    max_blk_count;
>         unsigned short                  max_segs;
>         void (*set_pwr)(struct platform_device *host, int state);
> -       void (*set_clk_div)(struct platform_device *host, int state);
>  };
>
>  /*
> --
> 2.34.1
>
>

Re: [PATCH 2/2] mmc: tmio: Remove obsolete .set_pwr() callback()

[Lad, Prabhakar]

On Thu, Jun 20, 2024 at 4:40 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> Commit ca78476e4888f1f1 ("mfd: Remove toshiba tmio drivers") removed the
> last users of the .set_pwr() callback in the tmio_mmc_data structure.
> Remove the callback, and all related infrastructure.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Laurent tried this before in commit 3af9d15c719017fe
> ("mmc: tmio-mmc: Remove .set_pwr() callback from platform data"),
> but it had to be reverted in commit 9d731e7539713acc ("Revert
> "mmc: tmio-mmc: Remove .set_pwr() callback from platform data"")
> because there were still users at that time.
> ---
>  drivers/mmc/host/tmio_mmc.h      | 3 ---
>  drivers/mmc/host/tmio_mmc_core.c | 8 --------
>  include/linux/mfd/tmio.h         | 1 -
>  3 files changed, 12 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h
> index de56e6534aeaaa10..2af5730c21f4a98d 100644
> --- a/drivers/mmc/host/tmio_mmc.h
> +++ b/drivers/mmc/host/tmio_mmc.h
> @@ -139,9 +139,6 @@ struct tmio_mmc_host {
>         struct mmc_host         *mmc;
>         struct mmc_host_ops     ops;
>
> -       /* Callbacks for clock / power control */
> -       void (*set_pwr)(struct platform_device *host, int state);
> -
>         /* pio related stuff */
>         struct scatterlist      *sg_ptr;
>         struct scatterlist      *sg_orig;
> diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c
> index 93e912afd3ae5aa0..7b4256f0cbe77028 100644
> --- a/drivers/mmc/host/tmio_mmc_core.c
> +++ b/drivers/mmc/host/tmio_mmc_core.c
> @@ -880,9 +880,6 @@ static void tmio_mmc_power_on(struct tmio_mmc_host *host, unsigned short vdd)
>
>         /* .set_ios() is returning void, so, no chance to report an error */
>
> -       if (host->set_pwr)
> -               host->set_pwr(host->pdev, 1);
> -
>         if (!IS_ERR(mmc->supply.vmmc)) {
>                 ret = mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, vdd);
>                 /*
> @@ -916,9 +913,6 @@ static void tmio_mmc_power_off(struct tmio_mmc_host *host)
>
>         if (!IS_ERR(mmc->supply.vmmc))
>                 mmc_regulator_set_ocr(mmc, mmc->supply.vmmc, 0);
> -
> -       if (host->set_pwr)
> -               host->set_pwr(host->pdev, 0);
>  }
>
>  static unsigned int tmio_mmc_get_timeout_cycles(struct tmio_mmc_host *host)
> @@ -1160,8 +1154,6 @@ int tmio_mmc_host_probe(struct tmio_mmc_host *_host)
>         if (pdata->flags & TMIO_MMC_USE_BUSY_TIMEOUT && !_host->get_timeout_cycles)
>                 _host->get_timeout_cycles = tmio_mmc_get_timeout_cycles;
>
> -       _host->set_pwr = pdata->set_pwr;
> -
>         ret = tmio_mmc_init_ocr(_host);
>         if (ret < 0)
>                 return ret;
> diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
> index aca74ac1ff69e6f7..8c09d14a3a286ca0 100644
> --- a/include/linux/mfd/tmio.h
> +++ b/include/linux/mfd/tmio.h
> @@ -100,7 +100,6 @@ struct tmio_mmc_data {
>         dma_addr_t                      dma_rx_offset;
>         unsigned int                    max_blk_count;
>         unsigned short                  max_segs;
> -       void (*set_pwr)(struct platform_device *host, int state);
>  };
>
>  /*
> --
> 2.34.1
>
>

Re: [PATCH 1/2] mfd: tmio: Remove obsolete .set_clk_div() callback

[Geert Uytterhoeven]

Hi Lee,

On Thu, Jun 20, 2024 at 7:08 PM Lee Jones <lee@kernel.org> wrote:
> On Thu, 20 Jun 2024, Geert Uytterhoeven wrote:
> > Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last
> > user of the .set_clk_div() callback in the tmio_mmc_data structure.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >  include/linux/mfd/tmio.h | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
> > index eace8ea6cda05a3d..aca74ac1ff69e6f7 100644
> > --- a/include/linux/mfd/tmio.h
> > +++ b/include/linux/mfd/tmio.h
> > @@ -101,7 +101,6 @@ struct tmio_mmc_data {
> >       unsigned int                    max_blk_count;
> >       unsigned short                  max_segs;
> >       void (*set_pwr)(struct platform_device *host, int state);
> > -     void (*set_clk_div)(struct platform_device *host, int state);
>
> Any ramifications for just hoovering this up?

I am sorry, I am not familiar with that expression.
Can you please elaborate?
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/2] mfd: tmio: Remove obsolete .set_clk_div() callback

[Lee Jones]

On Mon, 24 Jun 2024, Geert Uytterhoeven wrote:

> Hi Lee,
> 
> On Thu, Jun 20, 2024 at 7:08 PM Lee Jones <lee@kernel.org> wrote:
> > On Thu, 20 Jun 2024, Geert Uytterhoeven wrote:
> > > Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last
> > > user of the .set_clk_div() callback in the tmio_mmc_data structure.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > >  include/linux/mfd/tmio.h | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
> > > index eace8ea6cda05a3d..aca74ac1ff69e6f7 100644
> > > --- a/include/linux/mfd/tmio.h
> > > +++ b/include/linux/mfd/tmio.h
> > > @@ -101,7 +101,6 @@ struct tmio_mmc_data {
> > >       unsigned int                    max_blk_count;
> > >       unsigned short                  max_segs;
> > >       void (*set_pwr)(struct platform_device *host, int state);
> > > -     void (*set_clk_div)(struct platform_device *host, int state);
> >
> > Any ramifications for just hoovering this up?
> 
> I am sorry, I am not familiar with that expression.
> Can you please elaborate?
> Thanks!

If I take _only_ this patch and leave the MMC one, will something break?

-- 
Lee Jones [李琼斯]

Re: [PATCH 1/2] mfd: tmio: Remove obsolete .set_clk_div() callback

[Geert Uytterhoeven]

Hi Lee,

On Mon, Jun 24, 2024 at 12:46 PM Lee Jones <lee@kernel.org> wrote:
> On Mon, 24 Jun 2024, Geert Uytterhoeven wrote:
> > On Thu, Jun 20, 2024 at 7:08 PM Lee Jones <lee@kernel.org> wrote:
> > > On Thu, 20 Jun 2024, Geert Uytterhoeven wrote:
> > > > Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last
> > > > user of the .set_clk_div() callback in the tmio_mmc_data structure.
> > > >
> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > ---
> > > >  include/linux/mfd/tmio.h | 1 -
> > > >  1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
> > > > index eace8ea6cda05a3d..aca74ac1ff69e6f7 100644
> > > > --- a/include/linux/mfd/tmio.h
> > > > +++ b/include/linux/mfd/tmio.h
> > > > @@ -101,7 +101,6 @@ struct tmio_mmc_data {
> > > >       unsigned int                    max_blk_count;
> > > >       unsigned short                  max_segs;
> > > >       void (*set_pwr)(struct platform_device *host, int state);
> > > > -     void (*set_clk_div)(struct platform_device *host, int state);
> > >
> > > Any ramifications for just hoovering this up?
> >
> > I am sorry, I am not familiar with that expression.
> > Can you please elaborate?
> > Thanks!
>
> If I take _only_ this patch and leave the MMC one, will something break?

No, nothing will break.

It will just (a) make it a tad more difficult to apply the second patch
to the MMC tree, as it has a contextual dependency on the first patch,
and (b) cause a merge conflict for linux-next and Linus later...
Perhaps it would be easier to just provide an Acked-by, like you have
already done for the second patch?

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/2] mfd: tmio: Remove obsolete .set_clk_div() callback

[Lee Jones]

On Mon, 24 Jun 2024, Geert Uytterhoeven wrote:

> Hi Lee,
> 
> On Mon, Jun 24, 2024 at 12:46 PM Lee Jones <lee@kernel.org> wrote:
> > On Mon, 24 Jun 2024, Geert Uytterhoeven wrote:
> > > On Thu, Jun 20, 2024 at 7:08 PM Lee Jones <lee@kernel.org> wrote:
> > > > On Thu, 20 Jun 2024, Geert Uytterhoeven wrote:
> > > > > Commit bef64d2908e825c5 ("mmc: remove tmio_mmc driver") removed the last
> > > > > user of the .set_clk_div() callback in the tmio_mmc_data structure.
> > > > >
> > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > > ---
> > > > >  include/linux/mfd/tmio.h | 1 -
> > > > >  1 file changed, 1 deletion(-)
> > > > >
> > > > > diff --git a/include/linux/mfd/tmio.h b/include/linux/mfd/tmio.h
> > > > > index eace8ea6cda05a3d..aca74ac1ff69e6f7 100644
> > > > > --- a/include/linux/mfd/tmio.h
> > > > > +++ b/include/linux/mfd/tmio.h
> > > > > @@ -101,7 +101,6 @@ struct tmio_mmc_data {
> > > > >       unsigned int                    max_blk_count;
> > > > >       unsigned short                  max_segs;
> > > > >       void (*set_pwr)(struct platform_device *host, int state);
> > > > > -     void (*set_clk_div)(struct platform_device *host, int state);
> > > >
> > > > Any ramifications for just hoovering this up?
> > >
> > > I am sorry, I am not familiar with that expression.
> > > Can you please elaborate?
> > > Thanks!
> >
> > If I take _only_ this patch and leave the MMC one, will something break?
> 
> No, nothing will break.
> 
> It will just (a) make it a tad more difficult to apply the second patch
> to the MMC tree, as it has a contextual dependency on the first patch,
> and (b) cause a merge conflict for linux-next and Linus later...
> Perhaps it would be easier to just provide an Acked-by, like you have
> already done for the second patch?

Considering this is only a one-liner, this should be okay.

Acked-by: Lee Jones <lee@kernel.org>

-- 
Lee Jones [李琼斯]

Re: [PATCH 0/2] mmc: tmio: Remove obsolete callbacks

[Ulf Hansson]

On Thu, 20 Jun 2024 at 17:39, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
>         Hi all,
>
> This patch series removes two unused callbacks from the tmio_mmc_data
> structure, and related infrastructure code.
>   - The first patch touches only the MFD subsystem.
>   - The second patch touches both the MMC and MFD subsystems, and has a
>     contextual dependency on the first patch.  If really needed, it can
>     be split in an MMC and MFD part, but the MFD part depends on the MMC
>     part anyway.
>
> Thanks for your comments!
>
> Geert Uytterhoeven (2):
>   mfd: tmio: Remove obsolete .set_clk_div() callback
>   mmc: tmio: Remove obsolete .set_pwr() callback()
>
>  drivers/mmc/host/tmio_mmc.h      | 3 ---
>  drivers/mmc/host/tmio_mmc_core.c | 8 --------
>  include/linux/mfd/tmio.h         | 2 --
>  3 files changed, 13 deletions(-)
>
> --

Applied for next, thanks!

Kind regards
Uffe