From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Courbot Subject: Re: [PATCH 1/4] mmc: slot-gpio: switch to use flags when getting GPIO Date: Wed, 24 Sep 2014 16:38:18 +0900 Message-ID: References: <1409137253-25189-1-git-send-email-linus.walleij@linaro.org> <541FDBC0.4020302@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-ig0-f176.google.com ([209.85.213.176]:42596 "EHLO mail-ig0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752796AbaIXHij (ORCPT ); Wed, 24 Sep 2014 03:38:39 -0400 In-Reply-To: Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Linus Walleij Cc: Adrian Hunter , Alexandre Courbot , Ulf Hansson , linux-mmc , Chris Ball , "linux-gpio@vger.kernel.org" On Mon, Sep 22, 2014 at 9:37 PM, Linus Walleij wrote: > On Mon, Sep 22, 2014 at 10:20 AM, Adrian Hunter wrote: > >> Unfortunately it doesn't seem to work. I needed the patch >> below. >> >> >> From: Adrian Hunter >> Date: Mon, 22 Sep 2014 11:01:16 +0300 >> Subject: [PATCH] gpio: Fix gpio direction flags not getting set >> >> GPIO direction flags are not getting set because >> an 'if' statement is the wrong way around. >> >> Signed-off-by: Adrian Hunter > > Oopps that's a bug, patch applied for fixes, so it'll work when > this hits upstream. > > Alex: confirm? Oh yes absolutely, this was a mistake of mine. Thanks and sorry for the inconvenience.