From: Linus Walleij <linus.walleij@linaro.org>
To: Chris Ball <cjb@laptop.org>
Cc: Johan Rudholm <jrudholm@gmail.com>,
Johan Rudholm <johan.rudholm@stericsson.com>,
linux-mmc@vger.kernel.org, Per Forlin <per.forlin@stericsson.com>,
Ulf Hansson <ulf.hansson@stericsson.com>
Subject: Re: [PATCH] mmc: card: Do not scan boot partitions
Date: Thu, 21 Jun 2012 10:05:08 +0200 [thread overview]
Message-ID: <CACRpkda+9G6Xawk14NOx05Osm9rmJNNe8wbiDKbMgrrEP1CPJw@mail.gmail.com> (raw)
In-Reply-To: <87txy53mva.fsf@octavius.laptop.org>
On Wed, Jun 20, 2012 at 7:38 PM, Chris Ball <cjb@laptop.org> wrote:
> On Wed, Jun 20 2012, Linus Walleij wrote:
>>
>> Like we add a Kconfig bool option "support partition scanning on boot
>> partitions" and then we default that to "n", so systems that really
>> want to do that can turn it on the day they need it.
>
> I'm not so happy with adding Kconfig options for configuring driver
> behavior -- it's usually a failure to just do the right thing.
This is not for drivers but for the core. But I get the idea...
> If we think that people might want to use a partition table on their
> boot partitions then we should just support doing that, as we do now.
OK in that case I think it's better to disallow partition tables
on the boot partitions, then the day someone has a valid usecase
we can add it back.
So then the patch is good as it is to me:
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
prev parent reply other threads:[~2012-06-21 8:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 13:04 [PATCH] mmc: card: Do not scan boot partitions Johan Rudholm
2012-06-20 6:18 ` Chris Ball
2012-06-20 7:27 ` Johan Rudholm
2012-06-20 7:51 ` Ulf Hansson
2012-06-20 8:55 ` Linus Walleij
2012-06-20 14:04 ` Johan Rudholm
2012-06-20 17:38 ` Chris Ball
2012-06-21 8:05 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkda+9G6Xawk14NOx05Osm9rmJNNe8wbiDKbMgrrEP1CPJw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=cjb@laptop.org \
--cc=johan.rudholm@stericsson.com \
--cc=jrudholm@gmail.com \
--cc=linux-mmc@vger.kernel.org \
--cc=per.forlin@stericsson.com \
--cc=ulf.hansson@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).