From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] mmc: card: Do not scan boot partitions Date: Thu, 21 Jun 2012 10:05:08 +0200 Message-ID: References: <1339506253-7164-1-git-send-email-johan.rudholm@stericsson.com> <87oboe4ibk.fsf@octavius.laptop.org> <87txy53mva.fsf@octavius.laptop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-wg0-f44.google.com ([74.125.82.44]:62650 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753554Ab2FUIFJ (ORCPT ); Thu, 21 Jun 2012 04:05:09 -0400 Received: by wgbdr13 with SMTP id dr13so373313wgb.1 for ; Thu, 21 Jun 2012 01:05:08 -0700 (PDT) In-Reply-To: <87txy53mva.fsf@octavius.laptop.org> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Chris Ball Cc: Johan Rudholm , Johan Rudholm , linux-mmc@vger.kernel.org, Per Forlin , Ulf Hansson On Wed, Jun 20, 2012 at 7:38 PM, Chris Ball wrote: > On Wed, Jun 20 2012, Linus Walleij wrote: >> >> Like we add a Kconfig bool option "support partition scanning on boot >> partitions" and then we default that to "n", so systems that really >> want to do that can turn it on the day they need it. > > I'm not so happy with adding Kconfig options for configuring driver > behavior -- it's usually a failure to just do the right thing. This is not for drivers but for the core. But I get the idea... > If we think that people might want to use a partition table on their > boot partitions then we should just support doing that, as we do now. OK in that case I think it's better to disallow partition tables on the boot partitions, then the day someone has a valid usecase we can add it back. So then the patch is good as it is to me: Acked-by: Linus Walleij Yours, Linus Walleij