From: Linus Walleij <linus.walleij@linaro.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] mmc: sdhci: Stop advertising the driver in dmesg
Date: Mon, 13 Oct 2025 15:16:27 +0200 [thread overview]
Message-ID: <CACRpkda32Dw8sxkfDy9i19UP-59H-3WPNhffKLn+Pi7UgQ54vQ@mail.gmail.com> (raw)
In-Reply-To: <82b1d733-df39-4f20-8f69-69b34bfac3b5@intel.com>
On Thu, Oct 9, 2025 at 8:11 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
> On 08/10/2025 01:04, Linus Walleij wrote:
> > As much as we have grown used to seeing this message on
> > every kernel boot, it does not add any technical value.
> >
> > Drop all messages from sdhci_drv_init().
> >
> > We need to keep the module_init/exit() calls to stub
> > functions for the module to work according to
> > <linux/module.h>.
>
> But is that true?
I don't know, I don't have an SDHCI device at hand to test..
The comments say:
/* Each module must use one module_init(). */
And for module_exit():
/* This is only required if you want to be unloadable. */
If it's not true we need to fix the docs as well...
But I discussed it with Ulf in the office last week and he was
frantically testing out dropping it altogether.
Yours,
Linus Walleij
prev parent reply other threads:[~2025-10-13 13:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-07 22:04 [PATCH v2] mmc: sdhci: Stop advertising the driver in dmesg Linus Walleij
2025-10-09 6:11 ` Adrian Hunter
2025-10-13 13:16 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkda32Dw8sxkfDy9i19UP-59H-3WPNhffKLn+Pi7UgQ54vQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).