[PATCH v2] mmc: sdhci: Stop advertising the driver in dmesg

[PATCH v2] mmc: sdhci: Stop advertising the driver in dmesg

[Linus Walleij]

As much as we have grown used to seeing this message on
every kernel boot, it does not add any technical value.

Drop all messages from sdhci_drv_init().

We need to keep the module_init/exit() calls to stub
functions for the module to work according to
<linux/module.h>.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
Changes in v2:
- Drop all the messages instead of demoting.
- Link to v1: https://lore.kernel.org/r/20251007-mmc-no-advert-v1-1-0e16989d28ef@linaro.org
---
 drivers/mmc/host/sdhci.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index ac7e11f37af71fa5a70eb579fd812227b9347f83..2025b33bd6bfb51fc3116148299807054179b2e2 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -4999,10 +4999,6 @@ EXPORT_SYMBOL_GPL(sdhci_remove_host);
 
 static int __init sdhci_drv_init(void)
 {
-	pr_info(DRIVER_NAME
-		": Secure Digital Host Controller Interface driver\n");
-	pr_info(DRIVER_NAME ": Copyright(c) Pierre Ossman\n");
-
 	return 0;
 }
 

---
base-commit: fd94619c43360eb44d28bd3ef326a4f85c600a07
change-id: 20251007-mmc-no-advert-8f5646c44dd6

Best regards,
-- 
Linus Walleij <linus.walleij@linaro.org>

Re: [PATCH v2] mmc: sdhci: Stop advertising the driver in dmesg

[Adrian Hunter]

On 08/10/2025 01:04, Linus Walleij wrote:
> As much as we have grown used to seeing this message on
> every kernel boot, it does not add any technical value.
> 
> Drop all messages from sdhci_drv_init().
> 
> We need to keep the module_init/exit() calls to stub
> functions for the module to work according to
> <linux/module.h>.

But is that true?

> 
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Changes in v2:
> - Drop all the messages instead of demoting.
> - Link to v1: https://lore.kernel.org/r/20251007-mmc-no-advert-v1-1-0e16989d28ef@linaro.org
> ---
>  drivers/mmc/host/sdhci.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index ac7e11f37af71fa5a70eb579fd812227b9347f83..2025b33bd6bfb51fc3116148299807054179b2e2 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -4999,10 +4999,6 @@ EXPORT_SYMBOL_GPL(sdhci_remove_host);
>  
>  static int __init sdhci_drv_init(void)
>  {
> -	pr_info(DRIVER_NAME
> -		": Secure Digital Host Controller Interface driver\n");
> -	pr_info(DRIVER_NAME ": Copyright(c) Pierre Ossman\n");
> -
>  	return 0;
>  }
>  
> 
> ---
> base-commit: fd94619c43360eb44d28bd3ef326a4f85c600a07
> change-id: 20251007-mmc-no-advert-8f5646c44dd6
> 
> Best regards,

Re: [PATCH v2] mmc: sdhci: Stop advertising the driver in dmesg

[Linus Walleij]

On Thu, Oct 9, 2025 at 8:11 AM Adrian Hunter <adrian.hunter@intel.com> wrote:
> On 08/10/2025 01:04, Linus Walleij wrote:
> > As much as we have grown used to seeing this message on
> > every kernel boot, it does not add any technical value.
> >
> > Drop all messages from sdhci_drv_init().
> >
> > We need to keep the module_init/exit() calls to stub
> > functions for the module to work according to
> > <linux/module.h>.
>
> But is that true?

I don't know, I don't have an SDHCI device at hand to test..

The comments say:

/* Each module must use one module_init(). */

And for module_exit():

/* This is only required if you want to be unloadable. */

If it's not true we need to fix the docs as well...

But I discussed it with Ulf in the office last week and he was
frantically testing out dropping it altogether.

Yours,
Linus Walleij