From: Linus Walleij <linus.walleij@linaro.org>
To: Yann Gautier <yann.gautier@foss.st.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Russell King <linux@armlinux.org.uk>,
Ludovic Barre <ludovic.barre@st.com>
Subject: Re: [PATCH v2] mmc: mmci: De-assert reset on probe
Date: Thu, 1 Jul 2021 17:39:01 +0200 [thread overview]
Message-ID: <CACRpkdbLB2FKFcTjpEJMqoh8NbWM80X0jsRB-Wb0eWmg+9h6Xw@mail.gmail.com> (raw)
In-Reply-To: <4b20c870-ee41-6455-bc28-07f89591c3f9@foss.st.com>
On Thu, Jul 1, 2021 at 2:39 PM Yann Gautier <yann.gautier@foss.st.com> wrote:
> I was wondering on which HW you saw this issue?
Haven't really seen it, but on ux500 we have no less that 6 (!)
mmci blocks and it wouldn't surprise me if some of them are
left in reset. Better safe than sorry.
> But I've seen this kind of thing is also done in some other drivers, so
> maybe it is just an alignment?
It is good to deassert any reset line explicitly if you have them,
I think.
> Anyway I tested it on STM32MP157C-EV1 board, so feel free to add my:
> Tested-by: Yann Gautier <yann.gautier@foss.st.com>
Thanks!
Linus Walleij
next prev parent reply other threads:[~2021-07-01 15:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 10:24 [PATCH v2] mmc: mmci: De-assert reset on probe Linus Walleij
2021-07-01 12:38 ` Yann Gautier
2021-07-01 15:39 ` Linus Walleij [this message]
2021-07-08 12:42 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbLB2FKFcTjpEJMqoh8NbWM80X0jsRB-Wb0eWmg+9h6Xw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=ludovic.barre@st.com \
--cc=ulf.hansson@linaro.org \
--cc=yann.gautier@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).