linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Sujit Reddy Thumma <sthumma@codeaurora.org>,
	Per Forlin <per.friden@stericsson.com>
Cc: linux-mmc@vger.kernel.org, cjb@laptop.org
Subject: Re: [PATCH] mmc: core: Ensure clocks are always enabled before host interaction
Date: Fri, 30 Dec 2011 03:14:09 +0100	[thread overview]
Message-ID: <CACRpkdbZS7TxKSpKR0DV4TC4dOzO_q83U1bd0HonKC2GBDBOgA@mail.gmail.com> (raw)
In-Reply-To: <1323678104-28854-1-git-send-email-sthumma@codeaurora.org>

On Mon, Dec 12, 2011 at 9:21 AM, Sujit Reddy Thumma
<sthumma@codeaurora.org> wrote:

> Ensure clocks are always enabled before any interaction with the
> host controller driver. This makes sure that there is no race
> between host execution and the core layer turning off clocks
> in different context with clock gating framework.
>
> Signed-off-by: Sujit Reddy Thumma <sthumma@codeaurora.org>

I guess Per Förlin may not be available, but would have preferred to
have his view on this as well, since he knows the semantics of
pre/post-req.

However from my PoV it looks nice and clean, and you surely have
done some serious testing on things like SDIO so:
Acked-by: Linus Walleij <linus.walleij@linaro.org>

Thanks,
Linus Walleij

  parent reply	other threads:[~2011-12-30  2:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-12  8:21 [PATCH] mmc: core: Ensure clocks are always enabled before host interaction Sujit Reddy Thumma
2011-12-12  9:12 ` Subhash Jadavani
2011-12-27  4:53   ` Sujit Reddy Thumma
2011-12-30  2:14 ` Linus Walleij [this message]
2012-01-24  3:44   ` Sujit Reddy Thumma
2012-01-30 12:48     ` Per Forlin
2012-01-30 19:33       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdbZS7TxKSpKR0DV4TC4dOzO_q83U1bd0HonKC2GBDBOgA@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=cjb@laptop.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=per.friden@stericsson.com \
    --cc=sthumma@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).