linux-mmc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
	Jaehoon Chung <jh80.chung@samsung.com>,
	Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH V2] mmc: block: Use __mmc_send_status() and drop get_card_status()
Date: Tue, 23 May 2017 22:53:15 +0200	[thread overview]
Message-ID: <CACRpkdbuU2B60CFME9sU=SbiYRFGr+CWekN3PmMA9DLc9WhBqw@mail.gmail.com> (raw)
In-Reply-To: <1495441438-5129-1-git-send-email-ulf.hansson@linaro.org>

On Mon, May 22, 2017 at 10:23 AM, Ulf Hansson <ulf.hansson@linaro.org> wrote:

> The only reason to why the mmc block device driver needs to implements its
> own version of how to get the status of the card, is that it needs to
> specify a different amount of retries.
>
> Therefore add a new exported function which allows the caller to specify
> the number of retries and convert everybody to use it, as this simplifies
> the code.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
>
> Changes in v2:
>         - Allow callers to specify retries.

Im allergic to __prefixes so I would call this:

> -int mmc_send_status(struct mmc_card *card, u32 *status)
> +int __mmc_send_status(struct mmc_card *card, u32 *status, unsigned int retries)

mmc_send_status_command()

Either way, it's a clever patch so:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

      reply	other threads:[~2017-05-23 20:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-22  8:23 [PATCH V2] mmc: block: Use __mmc_send_status() and drop get_card_status() Ulf Hansson
2017-05-23 20:53 ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdbuU2B60CFME9sU=SbiYRFGr+CWekN3PmMA9DLc9WhBqw@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=adrian.hunter@intel.com \
    --cc=jh80.chung@samsung.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).