From: Ben Chuang <benchuanggli@gmail.com>
To: Samuel Zou <zou_wei@huawei.com>, Ulf Hansson <ulf.hansson@linaro.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] mmc: sdhci-pci-gli: Make sdhci_pci_gli_resume static
Date: Fri, 8 May 2020 15:32:02 +0800 [thread overview]
Message-ID: <CACT4zj_HHQxOO9cELfmRqrspuzCrMQXMWGRfdrRa14DW5_ZXKQ@mail.gmail.com> (raw)
>>On Thu, 7 May 2020 at 14:14, Samuel Zou <zou_wei@huawei.com> wrote:
>>
>> Fix the following sparse warning:
>>
>> drivers/mmc/host/sdhci-pci-gli.c:343:5: warning:
>> symbol 'sdhci_pci_gli_resume' was not declared. Should it be static?
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Signed-off-by: Samuel Zou <zou_wei@huawei.com>
>
>This actually fixes a commit that I on my fixes branch, which is also
>targeted for stable.
>
>Therefore, I decided to squash this into the offending commit and
>adding your sob tag, with a note about what you fixed.
>
>Kind regards
>Uffe
>
Thanks Samuel for fixed this issue.
Thanks Ulf for your help.
PS.
I use this email to reply because the company's email will have a
confidentiality clause in the letter.
Best regards,
Ben Chuang
>> ---
>> drivers/mmc/host/sdhci-pci-gli.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
>> index bdb6336..fd76aa6 100644
>> --- a/drivers/mmc/host/sdhci-pci-gli.c
>> +++ b/drivers/mmc/host/sdhci-pci-gli.c
>> @@ -340,7 +340,7 @@ static u32 sdhci_gl9750_readl(struct sdhci_host *host, int reg)
>> }
>>
>> #ifdef CONFIG_PM_SLEEP
>>-int sdhci_pci_gli_resume(struct sdhci_pci_chip *chip)
>> +static int sdhci_pci_gli_resume(struct sdhci_pci_chip *chip)
>>{
>> struct sdhci_pci_slot *slot = chip->slots[0];
>>
>>--
>>2.6.2
>>
next reply other threads:[~2020-05-08 7:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 7:32 Ben Chuang [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-05-07 12:20 [PATCH -next] mmc: sdhci-pci-gli: Make sdhci_pci_gli_resume static Samuel Zou
2020-05-07 13:16 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACT4zj_HHQxOO9cELfmRqrspuzCrMQXMWGRfdrRa14DW5_ZXKQ@mail.gmail.com \
--to=benchuanggli@gmail.com \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=zou_wei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).