From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Blumenstingl Subject: Re: [PATCH] mmc: meson-mx-sdio: mark expected switch fall-through Date: Fri, 5 Oct 2018 23:10:12 +0200 Message-ID: References: <20181005100903.GA32057@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20181005100903.GA32057@embeddedor.com> Sender: linux-kernel-owner@vger.kernel.org To: gustavo@embeddedor.com Cc: ulf.hansson@linaro.org, carlo@caione.org, khilman@baylibre.com, linux-amlogic@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-mmc@vger.kernel.org On Fri, Oct 5, 2018 at 12:15 PM Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case, I replaced the "fall-through:" > comment with a proper "fall through", which is what GCC is > expecting to find. > > Addresses-Coverity-ID: 1373880 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva Acked-by: Martin Blumenstingl thank you for taking care of this! Regards Martin