From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80C46C433FE for ; Wed, 25 May 2022 17:04:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S245528AbiEYREE (ORCPT ); Wed, 25 May 2022 13:04:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37480 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229551AbiEYRED (ORCPT ); Wed, 25 May 2022 13:04:03 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D0E651E48 for ; Wed, 25 May 2022 10:04:00 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id k30so30965777wrd.5 for ; Wed, 25 May 2022 10:04:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pensando.io; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=loFo61ZrCr4QaTZkLYB3/JVJBU50T2JZCagmaC/lyAw=; b=Z0B1Dtj6jth9CjXTTNew6KleYGbdoUTXOF3eLdqZhHVQRSY9Ky2118o70pkPI06R9P SCqgbQIPZdZ8A+6XSqyr1osIbRUQ8jpfM1SQtn6RlB5oIv/W8tbxbnvk+47CA+AWjest fU9lJTgzqMVV2QPEjcYrGH5PygljPkdVEauDmiwPjEtRcpCDBLpc0PmAXeWfj4pPKG7P pCI4ZM59v4xHiw267rYLRgaUgXjxAGW8u6XvjRKmXusnMKtuWVLzpPYgToPdkIedX47q k/L2+ukcxX0kz9hd85M5bc1W9/J2LevtOKtA1eKU2NrffXaDBmtVE2rifIsoXEy8zF78 gDxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=loFo61ZrCr4QaTZkLYB3/JVJBU50T2JZCagmaC/lyAw=; b=cWndoQtI/IClWV3N+Dqb1pxVdOajJPAw+QzaaUY4m7CEy9kWezYlXIc2C1sNRfGoq9 1JuMSCOmu81Q2bHcGlptMotPtOhXVzxrLeVD4YcyAJxhuBKZkUM93UxYoHnXnUbF489k A+WFCtwNUmNEb6qe4GNE2TbGZi7/auGV7jUrsVzPtgGXS49+rqIUwgvonsaDKj1T2skE xqho6kzb15wN6ZPAD7d7GTSTwoF5EFMwUpT7eZzQI+vxtwDJEk5io48Y/C8//hZDvfaM knLbmLhburtuxa2zPBHuvWuUdSamqHWx3ZZk7/OiXF5uBOCH4ItQtMrhcn0UOTaAjR+t skMQ== X-Gm-Message-State: AOAM530nLppW8Rr9Co8kp9v761TwAgYWWEIMO1+k2oCxjjy5+OVWTOmV yK9r52/tGdABmn37eNW0/IH6J8530VRDCT7Hzbcc44g3CD5qaeLR X-Google-Smtp-Source: ABdhPJzNHPfJp1XyqZV7qhrWcbxNk3IfEfV32VUdXbe3pQf8/N0AgRWU30h5jOGOB2lixvKXXGLLczV8CTTR/5Arbjg= X-Received: by 2002:a5d:5954:0:b0:20c:4d55:1388 with SMTP id e20-20020a5d5954000000b0020c4d551388mr28040155wri.90.1653498238868; Wed, 25 May 2022 10:03:58 -0700 (PDT) MIME-Version: 1.0 References: <20220406233648.21644-1-brad@pensando.io> <20220406233648.21644-5-brad@pensando.io> <20220412113739.xczqscungojcitrm@mobilestation> In-Reply-To: <20220412113739.xczqscungojcitrm@mobilestation> From: Brad Larson Date: Wed, 25 May 2022 10:03:48 -0700 Message-ID: Subject: Re: [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC To: Serge Semin Cc: Serge Semin , Linux ARM , Arnd Bergmann , Linus Walleij , Bartosz Golaszewski , Mark Brown , Adrian Hunter , Ulf Hansson , Olof Johansson , David Clear , "open list:GPIO SUBSYSTEM" , linux-spi , linux-mmc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org Hi Sergey, On Tue, Apr 12, 2022 at 4:37 AM Serge Semin wrote: > > > [PATCH 04/11] dt-bindings: spi: Add compatible for Pensando Elba SoC > > I think you need to be more specific in the patch title to what bindings > you are adding the new compatible string. Something like this > "dt-bindings: spi: cdns: ..." > The same concerns the patch "[PATCH 03/11] dt-bindings: mmc: Add Pensando > Elba SoC binding". > Otherwise it isn't clear to what schema you are adding the Elba SoC > support to. Thanks for the review, I'll add more specifics to the bindings patch title. Regards, Brad