From: Saugata Das <saugata.das@linaro.org>
To: Kyungmin Park <kmpark@infradead.org>
Cc: Seungwon Jeon <tgih.jun@samsung.com>,
linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/2] mmc: core: Support packed command feature of eMMC4.5
Date: Mon, 23 Jan 2012 15:43:59 +0530 [thread overview]
Message-ID: <CAKLKtzdYPsQBVym7aCAyM_m3A2wtXzdXVi589YNynvmK-ZY+iw@mail.gmail.com> (raw)
In-Reply-To: <CAH9JG2VNSUNYAqd9MUawf4a5Q6HfjE07KOOZ5dkYnzzuzc0KrA@mail.gmail.com>
On 20 January 2012 10:05, Kyungmin Park <kmpark@infradead.org> wrote:
> Hi,
>
> FYI: we get performance gain using packed command at write. however in
> case of small size read, there are some performance drop since
> protocol overhead.
> In normal case, read command uses read operation only, but in case of
> packed read. It sends the command to eMMC and read it.
> Anyway it's good feature for eMMC v4.5.
>
I believe the improvement will vary depending on how many commands are
packed, which will depend on use case (e.g. CPU load, rate of
application read/write), file system state (e.g. fragmentation, amount
of free space) etc. It will be very interesting if you can publish the
details of what you have tested and your observation of different
parameters related to packed command.
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
>
> On 1/20/12, Seungwon Jeon <tgih.jun@samsung.com> wrote:
>> This patch-set adds support of packed command feature
>> for eMMC4.5 devices.
>>
>> Changes in v3:
>> - Add a variable member in mmc_host for minimum number of packed entries.
>> This value can be overrided by host.
>> - Fix a handling of error sequence.
>>
>> Changes in v2:
>> - Fix the packed read sequence and error handling.
>> - Apply checking the exception status for all cases with
>> the comments from Maya Erez and Sahitya Tummala.
>> - Fix preparing the packed list with the comment from Maya Erez and
>> Venkatraman.
>>
>>
>> Seungwon Jeon (2):
>> mmc: core: Add packed command feature of eMMC4.5
>> mmc: core: Support packed command for eMMC4.5 device
>>
>> drivers/mmc/card/block.c | 469
>> +++++++++++++++++++++++++++++++++++++++++---
>> drivers/mmc/card/queue.c | 48 +++++-
>> drivers/mmc/card/queue.h | 13 ++
>> drivers/mmc/core/host.c | 2 +
>> drivers/mmc/core/mmc.c | 24 +++
>> drivers/mmc/core/mmc_ops.c | 1 +
>> include/linux/mmc/card.h | 3 +
>> include/linux/mmc/core.h | 3 +
>> include/linux/mmc/host.h | 4 +
>> include/linux/mmc/mmc.h | 15 ++
>> 10 files changed, 555 insertions(+), 27 deletions(-)
>>
>> Best regards,
>> Seungwon Jeon.
>> --
>> 1.7.2.3
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-01-23 10:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 4:05 [PATCH v3 0/2] mmc: core: Support packed command feature of eMMC4.5 Seungwon Jeon
2012-01-20 4:35 ` Kyungmin Park
2012-01-20 5:39 ` Namjae Jeon
2012-01-23 10:13 ` Saugata Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKLKtzdYPsQBVym7aCAyM_m3A2wtXzdXVi589YNynvmK-ZY+iw@mail.gmail.com \
--to=saugata.das@linaro.org \
--cc=cjb@laptop.org \
--cc=kmpark@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).