* [PATCH] mmc: sdhci-pxav3: Remove unused variable in sdhci_pxav3_remove()
@ 2014-08-08 15:32 Geert Uytterhoeven
2014-08-08 15:38 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2014-08-08 15:32 UTC (permalink / raw)
To: Chris Ball, Ulf Hansson, Laurent Pinchart
Cc: linux-mmc, linux-kernel, Geert Uytterhoeven
Commit 8f69e585ca3ad324ea57e113bff06d366dfa010e ("mmc: sdhci-pxav3: Use
devm_* managed helpers") removed the later user of pxa:
drivers/mmc/host/sdhci-pxav3.c: In function 'sdhci_pxav3_remove':
drivers/mmc/host/sdhci-pxav3.c:400:20: warning: unused variable 'pxa' [-Wunused-variable]
struct sdhci_pxa *pxa = pltfm_host->priv;
^
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/mmc/host/sdhci-pxav3.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
index 527dfa3faeab..6f842fb8e6b8 100644
--- a/drivers/mmc/host/sdhci-pxav3.c
+++ b/drivers/mmc/host/sdhci-pxav3.c
@@ -397,7 +397,6 @@ static int sdhci_pxav3_remove(struct platform_device *pdev)
{
struct sdhci_host *host = platform_get_drvdata(pdev);
struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
- struct sdhci_pxa *pxa = pltfm_host->priv;
pm_runtime_get_sync(&pdev->dev);
sdhci_remove_host(host, 1);
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci-pxav3: Remove unused variable in sdhci_pxav3_remove()
2014-08-08 15:32 [PATCH] mmc: sdhci-pxav3: Remove unused variable in sdhci_pxav3_remove() Geert Uytterhoeven
@ 2014-08-08 15:38 ` Laurent Pinchart
2014-08-08 15:50 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Pinchart @ 2014-08-08 15:38 UTC (permalink / raw)
To: Geert Uytterhoeven, linux-mmc; +Cc: Chris Ball, Ulf Hansson, linux-kernel
Hi Geert,
Thank you for the patch, but you're a bit too late :-)
http://article.gmane.org/gmane.linux.kernel.mmc/28097
On Friday 08 August 2014 17:32:11 Geert Uytterhoeven wrote:
> Commit 8f69e585ca3ad324ea57e113bff06d366dfa010e ("mmc: sdhci-pxav3: Use
> devm_* managed helpers") removed the later user of pxa:
>
> drivers/mmc/host/sdhci-pxav3.c: In function 'sdhci_pxav3_remove':
> drivers/mmc/host/sdhci-pxav3.c:400:20: warning: unused variable 'pxa'
> [-Wunused-variable] struct sdhci_pxa *pxa = pltfm_host->priv;
> ^
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/mmc/host/sdhci-pxav3.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
> index 527dfa3faeab..6f842fb8e6b8 100644
> --- a/drivers/mmc/host/sdhci-pxav3.c
> +++ b/drivers/mmc/host/sdhci-pxav3.c
> @@ -397,7 +397,6 @@ static int sdhci_pxav3_remove(struct platform_device
> *pdev) {
> struct sdhci_host *host = platform_get_drvdata(pdev);
> struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
> - struct sdhci_pxa *pxa = pltfm_host->priv;
>
> pm_runtime_get_sync(&pdev->dev);
> sdhci_remove_host(host, 1);
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mmc: sdhci-pxav3: Remove unused variable in sdhci_pxav3_remove()
2014-08-08 15:38 ` Laurent Pinchart
@ 2014-08-08 15:50 ` Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2014-08-08 15:50 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Geert Uytterhoeven, Linux MMC List, Chris Ball, Ulf Hansson,
linux-kernel@vger.kernel.org
On Fri, Aug 8, 2014 at 5:38 PM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> Thank you for the patch, but you're a bit too late :-)
>
> http://article.gmane.org/gmane.linux.kernel.mmc/28097
Doh, I'm not (yet) on linux-mmc.
It's a pity that fix is not yet in -next.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-08-08 15:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-08-08 15:32 [PATCH] mmc: sdhci-pxav3: Remove unused variable in sdhci_pxav3_remove() Geert Uytterhoeven
2014-08-08 15:38 ` Laurent Pinchart
2014-08-08 15:50 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).