From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haojian Zhuang Subject: Re: [PATCH v3 2/4] ARM: pxa168: Add SDHCI support Date: Mon, 19 Dec 2011 13:30:42 +0800 Message-ID: References: <87r51fwxgt.fsf@laptop.org> <1321849572-2944-1-git-send-email-tanmay.upadhyay@einfochips.com> <874nxkmaky.fsf@laptop.org> <4EEEC3BF.6010708@einfochips.com> <8B50F2A0-3991-4127-B3D9-5D69C70F87EF@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from mail-vw0-f46.google.com ([209.85.212.46]:57202 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750910Ab1LSFan (ORCPT ); Mon, 19 Dec 2011 00:30:43 -0500 Received: by vbbfc26 with SMTP id fc26so3745995vbb.19 for ; Sun, 18 Dec 2011 21:30:42 -0800 (PST) In-Reply-To: <8B50F2A0-3991-4127-B3D9-5D69C70F87EF@marvell.com> Sender: linux-mmc-owner@vger.kernel.org List-Id: linux-mmc@vger.kernel.org To: Philip Rakity Cc: Tanmay Upadhyay , Chris Ball , "linux-mmc@vger.kernel.org" , "eric.y.miao@gmail.com" , "linux-arm-kernel@lists.infradead.org" , Jason Chagas On Mon, Dec 19, 2011 at 1:24 PM, Philip Rakity wrote: > > Haojian, > > Should the APMU definitions be moved to a separate include for pxa168 and say given the name pxa168_apmu.h ? > > Same comment applies to all the register set since they are not really common. > > Philip I think it's unnecessary to create a new apmu.h. We can distinguish them by name in macro, as PXA168/MMP2. Thanks Haojian