From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH] mmc: meson-mx-sdio: mark expected switch fall-through Date: Fri, 5 Oct 2018 15:54:03 +0200 Message-ID: References: <20181005100903.GA32057@embeddedor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20181005100903.GA32057@embeddedor.com> Sender: linux-kernel-owner@vger.kernel.org To: "Gustavo A. R. Silva" Cc: Carlo Caione , Kevin Hilman , "linux-mmc@vger.kernel.org" , Linux ARM , "open list:ARM/Amlogic Meson..." , Linux Kernel Mailing List List-Id: linux-mmc@vger.kernel.org On 5 October 2018 at 12:09, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case, I replaced the "fall-through:" > comment with a proper "fall through", which is what GCC is > expecting to find. > > Addresses-Coverity-ID: 1373880 ("Missing break in switch") > Signed-off-by: Gustavo A. R. Silva Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/meson-mx-sdio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/meson-mx-sdio.c b/drivers/mmc/host/meson-mx-sdio.c > index 2cfec33..abe253c 100644 > --- a/drivers/mmc/host/meson-mx-sdio.c > +++ b/drivers/mmc/host/meson-mx-sdio.c > @@ -294,7 +294,7 @@ static void meson_mx_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios) > switch (ios->power_mode) { > case MMC_POWER_OFF: > vdd = 0; > - /* fall-through: */ > + /* fall through */ > case MMC_POWER_UP: > if (!IS_ERR(mmc->supply.vmmc)) { > host->error = mmc_regulator_set_ocr(mmc, > -- > 2.7.4 >