* [PATCH 1/1] dt-bindings: mmc: fsl,esdhc: Add explicit reference to mmc-controller-common
@ 2025-07-25 6:01 Alexander Stein
2025-07-25 23:35 ` Rob Herring
2025-08-18 10:54 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Alexander Stein @ 2025-07-25 6:01 UTC (permalink / raw)
To: Ulf Hansson, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Frank Li
Cc: Alexander Stein, linux-mmc, devicetree, linux-kernel
Even though it is referenced by mmc/mmc-controller.yaml it still raises
the warning:
esdhc@1560000 (fsl,ls1021a-esdhc): Unevaluated properties are not allowed ('bus-width' was unexpected)
Adding an explicit reference fixes this.
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
I don't know if this is a tooling problem or whatever. I would have
expected that mmc-controller-common.yaml is added via
mmc-controller.yaml. But apparently this is missing resulting in the
given warning. Hence adding the reference
Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml
index 62087cf920df8..f45e592901e24 100644
--- a/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml
+++ b/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml
@@ -90,6 +90,7 @@ required:
allOf:
- $ref: sdhci-common.yaml#
+ - $ref: mmc-controller-common.yaml#
unevaluatedProperties: false
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] dt-bindings: mmc: fsl,esdhc: Add explicit reference to mmc-controller-common
2025-07-25 6:01 [PATCH 1/1] dt-bindings: mmc: fsl,esdhc: Add explicit reference to mmc-controller-common Alexander Stein
@ 2025-07-25 23:35 ` Rob Herring
2025-08-18 10:54 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2025-07-25 23:35 UTC (permalink / raw)
To: Alexander Stein
Cc: Ulf Hansson, Krzysztof Kozlowski, Conor Dooley, Frank Li,
linux-mmc, devicetree, linux-kernel
On Fri, Jul 25, 2025 at 08:01:51AM +0200, Alexander Stein wrote:
> Even though it is referenced by mmc/mmc-controller.yaml it still raises
> the warning:
> esdhc@1560000 (fsl,ls1021a-esdhc): Unevaluated properties are not allowed ('bus-width' was unexpected)
>
> Adding an explicit reference fixes this.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> I don't know if this is a tooling problem or whatever. I would have
> expected that mmc-controller-common.yaml is added via
> mmc-controller.yaml. But apparently this is missing resulting in the
> given warning. Hence adding the reference
The issue is the nodename. Since validation of it fails, the whole
referenced schema is not 'evaluated' and bus-width is unevaluated. Best
I can tell, that's correct behavior for json-schema.
I guess this is an adequate work-around.
Acked-by: Rob Herring (Arm) <robh@kernel.org>
>
> Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml
> index 62087cf920df8..f45e592901e24 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml
> @@ -90,6 +90,7 @@ required:
>
> allOf:
> - $ref: sdhci-common.yaml#
> + - $ref: mmc-controller-common.yaml#
>
> unevaluatedProperties: false
>
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] dt-bindings: mmc: fsl,esdhc: Add explicit reference to mmc-controller-common
2025-07-25 6:01 [PATCH 1/1] dt-bindings: mmc: fsl,esdhc: Add explicit reference to mmc-controller-common Alexander Stein
2025-07-25 23:35 ` Rob Herring
@ 2025-08-18 10:54 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2025-08-18 10:54 UTC (permalink / raw)
To: Alexander Stein
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
linux-mmc, devicetree, linux-kernel
On Fri, 25 Jul 2025 at 08:02, Alexander Stein
<alexander.stein@ew.tq-group.com> wrote:
>
> Even though it is referenced by mmc/mmc-controller.yaml it still raises
> the warning:
> esdhc@1560000 (fsl,ls1021a-esdhc): Unevaluated properties are not allowed ('bus-width' was unexpected)
>
> Adding an explicit reference fixes this.
>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
> I don't know if this is a tooling problem or whatever. I would have
> expected that mmc-controller-common.yaml is added via
> mmc-controller.yaml. But apparently this is missing resulting in the
> given warning. Hence adding the reference
>
> Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml
> index 62087cf920df8..f45e592901e24 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fsl,esdhc.yaml
> @@ -90,6 +90,7 @@ required:
>
> allOf:
> - $ref: sdhci-common.yaml#
> + - $ref: mmc-controller-common.yaml#
>
> unevaluatedProperties: false
>
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-08-18 10:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-25 6:01 [PATCH 1/1] dt-bindings: mmc: fsl,esdhc: Add explicit reference to mmc-controller-common Alexander Stein
2025-07-25 23:35 ` Rob Herring
2025-08-18 10:54 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).