From: Ulf Hansson <ulf.hansson@linaro.org>
To: Chanwoo Lee <cw9316.lee@samsung.com>
Cc: Chaotian Jing <chaotian.jing@mediatek.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-mmc <linux-mmc@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
grant.jung@samsung.com, jt77.jang@samsung.com,
DooHyun Hwang <dh0421.hwang@samsung.com>,
Seunghui Lee <sh043.lee@samsung.com>
Subject: Re: [PATCH] mmc: mtk-sd: Remove unused parameters(mrq)
Date: Mon, 6 Sep 2021 19:10:00 +0200 [thread overview]
Message-ID: <CAPDyKFoXtep02GTFgKZmAoa7cN6CMBErf4UukWhrk5jU10Lj_g@mail.gmail.com> (raw)
In-Reply-To: <20210827093119.32481-1-cw9316.lee@samsung.com>
On Fri, 27 Aug 2021 at 11:39, Chanwoo Lee <cw9316.lee@samsung.com> wrote:
>
> From: ChanWoo Lee <cw9316.lee@samsung.com>
>
> The mmc_request structure(*mrq) is not used. //msdc_cmd_find_resp
> I remove the unnecessary code related to the mmc_request structure.
>
> Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com>
Queued for v5.16 on the temporary devel branch, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/mtk-sd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 4dfc246c5f95..813f57f6d9cc 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -961,7 +961,7 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz)
> }
>
> static inline u32 msdc_cmd_find_resp(struct msdc_host *host,
> - struct mmc_request *mrq, struct mmc_command *cmd)
> + struct mmc_command *cmd)
> {
> u32 resp;
>
> @@ -997,7 +997,7 @@ static inline u32 msdc_cmd_prepare_raw_cmd(struct msdc_host *host,
> * stop << 14 | rw << 13 | dtype << 11 | rsptyp << 7 | brk << 6 | opcode
> */
> u32 opcode = cmd->opcode;
> - u32 resp = msdc_cmd_find_resp(host, mrq, cmd);
> + u32 resp = msdc_cmd_find_resp(host, cmd);
> u32 rawcmd = (opcode & 0x3f) | ((resp & 0x7) << 7);
>
> host->cmd_rsp = resp;
> --
> 2.29.0
>
prev parent reply other threads:[~2021-09-06 17:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210827093855epcas1p4ac8e34d779fe30de3e03bcadedcb66c8@epcas1p4.samsung.com>
2021-08-27 9:31 ` [PATCH] mmc: mtk-sd: Remove unused parameters(mrq) Chanwoo Lee
2021-09-06 17:10 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFoXtep02GTFgKZmAoa7cN6CMBErf4UukWhrk5jU10Lj_g@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=chaotian.jing@mediatek.com \
--cc=cw9316.lee@samsung.com \
--cc=dh0421.hwang@samsung.com \
--cc=grant.jung@samsung.com \
--cc=jt77.jang@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=sh043.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).