* [PATCH] mmc: mtk-sd: Remove unused parameters(mrq) [not found] <CGME20210827093855epcas1p4ac8e34d779fe30de3e03bcadedcb66c8@epcas1p4.samsung.com> @ 2021-08-27 9:31 ` Chanwoo Lee 2021-09-06 17:10 ` Ulf Hansson 0 siblings, 1 reply; 2+ messages in thread From: Chanwoo Lee @ 2021-08-27 9:31 UTC (permalink / raw) To: chaotian.jing, ulf.hansson, matthias.bgg, linux-mmc, linux-arm-kernel, linux-mediatek, linux-kernel Cc: grant.jung, jt77.jang, dh0421.hwang, sh043.lee, ChanWoo Lee From: ChanWoo Lee <cw9316.lee@samsung.com> The mmc_request structure(*mrq) is not used. //msdc_cmd_find_resp I remove the unnecessary code related to the mmc_request structure. Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com> --- drivers/mmc/host/mtk-sd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 4dfc246c5f95..813f57f6d9cc 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -961,7 +961,7 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz) } static inline u32 msdc_cmd_find_resp(struct msdc_host *host, - struct mmc_request *mrq, struct mmc_command *cmd) + struct mmc_command *cmd) { u32 resp; @@ -997,7 +997,7 @@ static inline u32 msdc_cmd_prepare_raw_cmd(struct msdc_host *host, * stop << 14 | rw << 13 | dtype << 11 | rsptyp << 7 | brk << 6 | opcode */ u32 opcode = cmd->opcode; - u32 resp = msdc_cmd_find_resp(host, mrq, cmd); + u32 resp = msdc_cmd_find_resp(host, cmd); u32 rawcmd = (opcode & 0x3f) | ((resp & 0x7) << 7); host->cmd_rsp = resp; -- 2.29.0 ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mmc: mtk-sd: Remove unused parameters(mrq) 2021-08-27 9:31 ` [PATCH] mmc: mtk-sd: Remove unused parameters(mrq) Chanwoo Lee @ 2021-09-06 17:10 ` Ulf Hansson 0 siblings, 0 replies; 2+ messages in thread From: Ulf Hansson @ 2021-09-06 17:10 UTC (permalink / raw) To: Chanwoo Lee Cc: Chaotian Jing, Matthias Brugger, linux-mmc, Linux ARM, moderated list:ARM/Mediatek SoC support, Linux Kernel Mailing List, grant.jung, jt77.jang, DooHyun Hwang, Seunghui Lee On Fri, 27 Aug 2021 at 11:39, Chanwoo Lee <cw9316.lee@samsung.com> wrote: > > From: ChanWoo Lee <cw9316.lee@samsung.com> > > The mmc_request structure(*mrq) is not used. //msdc_cmd_find_resp > I remove the unnecessary code related to the mmc_request structure. > > Signed-off-by: ChanWoo Lee <cw9316.lee@samsung.com> Queued for v5.16 on the temporary devel branch, thanks! Kind regards Uffe > --- > drivers/mmc/host/mtk-sd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > index 4dfc246c5f95..813f57f6d9cc 100644 > --- a/drivers/mmc/host/mtk-sd.c > +++ b/drivers/mmc/host/mtk-sd.c > @@ -961,7 +961,7 @@ static void msdc_set_mclk(struct msdc_host *host, unsigned char timing, u32 hz) > } > > static inline u32 msdc_cmd_find_resp(struct msdc_host *host, > - struct mmc_request *mrq, struct mmc_command *cmd) > + struct mmc_command *cmd) > { > u32 resp; > > @@ -997,7 +997,7 @@ static inline u32 msdc_cmd_prepare_raw_cmd(struct msdc_host *host, > * stop << 14 | rw << 13 | dtype << 11 | rsptyp << 7 | brk << 6 | opcode > */ > u32 opcode = cmd->opcode; > - u32 resp = msdc_cmd_find_resp(host, mrq, cmd); > + u32 resp = msdc_cmd_find_resp(host, cmd); > u32 rawcmd = (opcode & 0x3f) | ((resp & 0x7) << 7); > > host->cmd_rsp = resp; > -- > 2.29.0 > ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-06 17:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20210827093855epcas1p4ac8e34d779fe30de3e03bcadedcb66c8@epcas1p4.samsung.com>
2021-08-27 9:31 ` [PATCH] mmc: mtk-sd: Remove unused parameters(mrq) Chanwoo Lee
2021-09-06 17:10 ` Ulf Hansson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).