From: Ulf Hansson <ulf.hansson@linaro.org>
To: Johan Rudholm <johan.rudholm@axis.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Chris Ball <chris@printf.net>, Jesper Nilsson <jespern@axis.com>,
Johan Rudholm <jrudholm@gmail.com>,
Johan Rudholm <johanru@axis.com>
Subject: Re: [PATCH] mmc: sd: warn if card stays busy during init
Date: Mon, 16 Jun 2014 12:20:35 +0200 [thread overview]
Message-ID: <CAPDyKFof=SfG2Dw3YVX2TNH7ts7nCHR+LYWHT1WS39vXxKHANw@mail.gmail.com> (raw)
In-Reply-To: <1400854503-9945-1-git-send-email-johanru@axis.com>
On 23 May 2014 16:15, Johan Rudholm <johan.rudholm@axis.com> wrote:
> The initialization of some SD-cards fails because the card never
> leaves the busy state. Aid trouble shooting by indicating this in the
> kernel log.
>
> Signed-off-by: Johan Rudholm <johanru@axis.com>
Thanks! Applied for next.
Kind regards
Uffe
> ---
> drivers/mmc/core/sd_ops.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mmc/core/sd_ops.c b/drivers/mmc/core/sd_ops.c
> index 274ef00..48d0c93 100644
> --- a/drivers/mmc/core/sd_ops.c
> +++ b/drivers/mmc/core/sd_ops.c
> @@ -184,6 +184,9 @@ int mmc_send_app_op_cond(struct mmc_host *host, u32 ocr, u32 *rocr)
> mmc_delay(10);
> }
>
> + if (!i)
> + pr_err("%s: card never left busy state\n", mmc_hostname(host));
> +
> if (rocr && !mmc_host_is_spi(host))
> *rocr = cmd.resp[0];
>
> --
> 1.7.2.5
>
prev parent reply other threads:[~2014-06-16 10:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 14:15 [PATCH] mmc: sd: warn if card stays busy during init Johan Rudholm
2014-06-16 10:20 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPDyKFof=SfG2Dw3YVX2TNH7ts7nCHR+LYWHT1WS39vXxKHANw@mail.gmail.com' \
--to=ulf.hansson@linaro.org \
--cc=chris@printf.net \
--cc=jespern@axis.com \
--cc=johan.rudholm@axis.com \
--cc=johanru@axis.com \
--cc=jrudholm@gmail.com \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).