From: Ulf Hansson <ulf.hansson@linaro.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Chris Ball <chris@printf.net>, linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] mmc-utils: Add Command Queue fields to Extended CSD
Date: Wed, 22 Jun 2016 12:26:26 +0200 [thread overview]
Message-ID: <CAPDyKFopB5c5zzsoxU_+dLZ55kSpNhWA0zEQgusqLP+iVnWsEw@mail.gmail.com> (raw)
In-Reply-To: <1465547339-10557-1-git-send-email-adrian.hunter@intel.com>
On 10 June 2016 at 10:28, Adrian Hunter <adrian.hunter@intel.com> wrote:
> Display Command Queue information when printing Extended CSD
> Example:
>
> # mmc extcsd read /dev/mmcblk0 | grep CMDQ
> Command Queue Support [CMDQ_SUPPORT]: 0x01
> Command Queue Depth [CMDQ_DEPTH]: 16
> Command Enabled [CMDQ_MODE_EN]: 0x01
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
> ---
> mmc.h | 3 +++
> mmc_cmds.c | 9 +++++++++
> 2 files changed, 12 insertions(+)
>
> diff --git a/mmc.h b/mmc.h
> index 8c77fd5572eb..a3d732c7215c 100644
> --- a/mmc.h
> +++ b/mmc.h
> @@ -55,6 +55,8 @@
> #define EXT_CSD_FFU_ARG_2 489 /* RO */
> #define EXT_CSD_FFU_ARG_1 488 /* RO */
> #define EXT_CSD_FFU_ARG_0 487 /* RO */
> +#define EXT_CSD_CMDQ_DEPTH 307 /* RO */
> +#define EXT_CSD_CMDQ_SUPPORT 308 /* RO */
> #define EXT_CSD_NUM_OF_FW_SEC_PROG_3 305 /* RO */
> #define EXT_CSD_NUM_OF_FW_SEC_PROG_2 304 /* RO */
> #define EXT_CSD_NUM_OF_FW_SEC_PROG_1 303 /* RO */
> @@ -119,6 +121,7 @@
> #define EXT_CSD_MODE_CONFIG 30
> #define EXT_CSD_MODE_OPERATION_CODES 29 /* W */
> #define EXT_CSD_FFU_STATUS 26 /* R */
> +#define EXT_CSD_CMDQ_MODE_EN 15 /* R/W */
>
> /*
> * WR_REL_PARAM field definitions
> diff --git a/mmc_cmds.c b/mmc_cmds.c
> index 36276106b7bf..295d50541dee 100644
> --- a/mmc_cmds.c
> +++ b/mmc_cmds.c
> @@ -1723,6 +1723,15 @@ int do_read_extcsd(int nargs, char **argv)
> printf("eMMC Firmware Version: %s\n",
> (char*)&ext_csd[EXT_CSD_FIRMWARE_VERSION]);
> }
> +
> + if (ext_csd_rev >= 8) {
> + printf("Command Queue Support [CMDQ_SUPPORT]: 0x%02x\n",
> + ext_csd[EXT_CSD_CMDQ_SUPPORT]);
> + printf("Command Queue Depth [CMDQ_DEPTH]: %u\n",
> + (ext_csd[EXT_CSD_CMDQ_DEPTH] & 0x1f) + 1);
> + printf("Command Enabled [CMDQ_MODE_EN]: 0x%02x\n",
> + ext_csd[EXT_CSD_CMDQ_MODE_EN]);
> + }
> out_free:
> return ret;
> }
> --
> 1.9.1
>
prev parent reply other threads:[~2016-06-22 10:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 8:28 [PATCH] mmc-utils: Add Command Queue fields to Extended CSD Adrian Hunter
2016-06-22 10:26 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFopB5c5zzsoxU_+dLZ55kSpNhWA0zEQgusqLP+iVnWsEw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=chris@printf.net \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).