From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 612BBC001DF for ; Wed, 16 Aug 2023 09:54:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243507AbjHPJxf (ORCPT ); Wed, 16 Aug 2023 05:53:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243619AbjHPJxE (ORCPT ); Wed, 16 Aug 2023 05:53:04 -0400 Received: from mail-yw1-x112b.google.com (mail-yw1-x112b.google.com [IPv6:2607:f8b0:4864:20::112b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32A642735 for ; Wed, 16 Aug 2023 02:52:47 -0700 (PDT) Received: by mail-yw1-x112b.google.com with SMTP id 00721157ae682-58c5642701fso17178527b3.0 for ; Wed, 16 Aug 2023 02:52:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692179566; x=1692784366; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/5so/M+AhEEk4mX4pqGb1Pa0ON/8pUQD4BvXmodkCBo=; b=XXivQr6n3Q1n02LmLFKvNhwy2ZFWWELsv6C48KCsw5fEHWPfYbexf3ffuIMEiinrek Y/X4tSzo9RTA+oD8AqmTQOgsypEgRI1IACIl6th69I5MJnHnpAM6DJzjnF0Vig6V1aXF nimlSnBQhrbLHZ2s9/9qQ+2wRcLW3iV6LeAAslAB2Vc7ZsHptr65tDb80MtKJEO+fhEx gmg5PQSqhuOoGgiKl3qCz6PKhZdX7xOEDfa2ZXLqY1AHRLRId8sQV3wxRBiLjFaqpwWS ydo7f/yZ0IdSZQaupZFLJMlf5LsvhRp4oFEi2n5u8qeurZCj9ighow94U2DidWpU4CAJ imVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692179566; x=1692784366; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/5so/M+AhEEk4mX4pqGb1Pa0ON/8pUQD4BvXmodkCBo=; b=alojFaRsxl9ND5/aG2vCw/6uJso0LvI0iBPHjfTgQOicGkuN146yv48eoRcOZmQuYr /BX9PbaaRE2LlSD5UXUm8oZtvkQ8C2FhpGDV37AfsScFgZxQn/60mtqNOPBkod0KvKtb Qx+scGnZg9LmN0aYEX+hHXAdYUt9pewmAXUFDeUK3flPx0zYlaN15TL05xVQnrhY1Fa8 /Wbzf0zS2pyZfQub8bVCy5YNKKxqu4rzplT2OCp2Zhmq5df8Drs4Zxov9VJdj+Rtng4g EkotUfn1XnuFYDXqNlMGCCIHFU4C4ateBByhiOT7wahqeoxQ3zNJ7D8drqG0lC8rzY+7 1Mtg== X-Gm-Message-State: AOJu0YwWbXHdRjW0kX4dyR6h8FmTqvkrAcMyxPr7tcuvKPufao8NFHdQ KVgLkqi1V13NbaQH0SNDLHHk4ED7GWgScSyOW3/1zQ== X-Google-Smtp-Source: AGHT+IHA9n2w/op4DAH5GzrBpdtTvK2/1xJVANiOu/xelGO0k7TIr+ajFJb7Jsxolv8ybqVetV/we8lj15rls0+GD54= X-Received: by 2002:a81:6057:0:b0:583:d1fa:1fc4 with SMTP id u84-20020a816057000000b00583d1fa1fc4mr1108904ywb.26.1692179566441; Wed, 16 Aug 2023 02:52:46 -0700 (PDT) MIME-Version: 1.0 References: <20230811214853.8623-1-giulio.benetti@benettiengineering.com> In-Reply-To: <20230811214853.8623-1-giulio.benetti@benettiengineering.com> From: Ulf Hansson Date: Wed, 16 Aug 2023 11:52:10 +0200 Message-ID: Subject: Re: [PATCH] mmc: sdhci-esdhc-imx: improve ESDHC_FLAG_ERR010450 To: Giulio Benetti Cc: Haibo Chen , Shawn Guo , Sascha Hauer , Fabio Estevam , NXP Linux Team , Adrian Hunter , Pengutronix Kernel Team , linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jim Reinhart , James Autry , Matthew Maron Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Fri, 11 Aug 2023 at 23:49, Giulio Benetti wrote: > > Errata ERR010450 only shows up if voltage is 1.8V, but if the device is > supplied by 3v3 the errata can be ignored. So let's check for if quirk > SDHCI_QUIRK2_NO_1_8_V is defined or not before limiting the frequency. > > Sponsored by: Tekvox Inc. Didn't know we have this kind of tag. Can you point me to the documentation of it? > Cc: Jim Reinhart > Cc: James Autry > Cc: Matthew Maron > Signed-off-by: Giulio Benetti Kind regards Uffe > --- > drivers/mmc/host/sdhci-esdhc-imx.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c > index eebf94604a7f..cddecc1e1ac2 100644 > --- a/drivers/mmc/host/sdhci-esdhc-imx.c > +++ b/drivers/mmc/host/sdhci-esdhc-imx.c > @@ -171,8 +171,8 @@ > #define ESDHC_FLAG_HS400 BIT(9) > /* > * The IP has errata ERR010450 > - * uSDHC: Due to the I/O timing limit, for SDR mode, SD card clock can't > - * exceed 150MHz, for DDR mode, SD card clock can't exceed 45MHz. > + * uSDHC: At 1.8V due to the I/O timing limit, for SDR mode, SD card > + * clock can't exceed 150MHz, for DDR mode, SD card clock can't exceed 45MHz. > */ > #define ESDHC_FLAG_ERR010450 BIT(10) > /* The IP supports HS400ES mode */ > @@ -961,7 +961,8 @@ static inline void esdhc_pltfm_set_clock(struct sdhci_host *host, > | ESDHC_CLOCK_MASK); > sdhci_writel(host, temp, ESDHC_SYSTEM_CONTROL); > > - if (imx_data->socdata->flags & ESDHC_FLAG_ERR010450) { > + if ((imx_data->socdata->flags & ESDHC_FLAG_ERR010450) && > + (!(host->quirks2 & SDHCI_QUIRK2_NO_1_8_V))) { > unsigned int max_clock; > > max_clock = imx_data->is_ddr ? 45000000 : 150000000; > -- > 2.34.1 >