From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10E4AC38A24 for ; Thu, 7 May 2020 13:16:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF1F020708 for ; Thu, 7 May 2020 13:16:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ThIIrlsU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725953AbgEGNQm (ORCPT ); Thu, 7 May 2020 09:16:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37800 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725948AbgEGNQl (ORCPT ); Thu, 7 May 2020 09:16:41 -0400 Received: from mail-vk1-xa43.google.com (mail-vk1-xa43.google.com [IPv6:2607:f8b0:4864:20::a43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2E8BC05BD09 for ; Thu, 7 May 2020 06:16:41 -0700 (PDT) Received: by mail-vk1-xa43.google.com with SMTP id v192so1602864vkd.3 for ; Thu, 07 May 2020 06:16:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aaEpYa065ypq35Huryl6ZF1r6VEE/Q7MGgbAu3JxSwc=; b=ThIIrlsUJAwhILFtB9W6ItdrMa51xrL79/VcpF9V+fVwinQVuierFP9YGkui0E51AG MNBHQbKmN8BblzRTnkoChsCjmAGWLXCniUBKIAiC08+XNh4ukMUOQ1VUz7NJ1nz8ULK6 0OuGzBWj1TUygr93F+Ts39jQIWDbwUCA0oigDafhNXTHG4xua/Jo4ajv/YJmQ9LkjFyM vKrL/YLtz2Qeo1m3Zjj8B0lOkUHTVEdU5ysKAk31NZjrv3Fa60YrxPjDfivsG5OXII/p CkJibs3Okh5v1+t8YP7PffYMi2hhnu/osVW8YoMQTbZEEsxTGqSFSBErV7tv7KRB7dIA ml0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aaEpYa065ypq35Huryl6ZF1r6VEE/Q7MGgbAu3JxSwc=; b=FdOHETHC+N83om2c9czP6Lu3frK0adkQRZQdDqyXhTZAr6K4wii9Iz/vuJOYk/oXuI EgLsEO0oXFDlew2uXm7VDsoIlNBZcUIBsrz/mOpte62mKG/QLgI4wTkdl1uW3QPbjQ59 cBE0MIPbRpjS4Lekd6EDUfIq8ZmjU7iThitLJJ+ulDpiKM3M8OD9ZU17rFFC2zVMBM01 UHINVU0Q2jb7D0wjRCPtD34cs0y/tdJdaRw6y04gZd/jWgG9DrzpVfu1hy629KxojqFy yhmhtMu0Vtx+S1LBPlWYNTnAq4U5s9cOi5w4wIeEtOHcILfQkFzSUeYIYKUz+0OWT8z6 j/UA== X-Gm-Message-State: AGi0PuZvk89F5QvcXSnHgIavUtzXyMaa19F2gCscSKmjmwBraKGED3S0 FHuHFtbhOPh1yzmeiyVUMZ0G1Io9RfW5sKWnltCrlA== X-Google-Smtp-Source: APiQypJ4tIZJqJGnORdByIJMHksJoo4U9LRFZ7eBQfYTSIzwh1Y7Uf/Jj5ZiYmcJvB//fjCenraX3JJb7xbs7uWkt3k= X-Received: by 2002:a1f:4845:: with SMTP id v66mr1168633vka.43.1588857400648; Thu, 07 May 2020 06:16:40 -0700 (PDT) MIME-Version: 1.0 References: <1588854050-19161-1-git-send-email-zou_wei@huawei.com> In-Reply-To: <1588854050-19161-1-git-send-email-zou_wei@huawei.com> From: Ulf Hansson Date: Thu, 7 May 2020 15:16:04 +0200 Message-ID: Subject: Re: [PATCH -next] mmc: sdhci-pci-gli: Make sdhci_pci_gli_resume static To: Samuel Zou Cc: Adrian Hunter , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-mmc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mmc@vger.kernel.org On Thu, 7 May 2020 at 14:14, Samuel Zou wrote: > > Fix the following sparse warning: > > drivers/mmc/host/sdhci-pci-gli.c:343:5: warning: > symbol 'sdhci_pci_gli_resume' was not declared. Should it be static? > > Reported-by: Hulk Robot > Signed-off-by: Samuel Zou This actually fixes a commit that I on my fixes branch, which is also targeted for stable. Therefore, I decided to squash this into the offending commit and adding your sob tag, with a note about what you fixed. Kind regards Uffe > --- > drivers/mmc/host/sdhci-pci-gli.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c > index bdb6336..fd76aa6 100644 > --- a/drivers/mmc/host/sdhci-pci-gli.c > +++ b/drivers/mmc/host/sdhci-pci-gli.c > @@ -340,7 +340,7 @@ static u32 sdhci_gl9750_readl(struct sdhci_host *host, int reg) > } > > #ifdef CONFIG_PM_SLEEP > -int sdhci_pci_gli_resume(struct sdhci_pci_chip *chip) > +static int sdhci_pci_gli_resume(struct sdhci_pci_chip *chip) > { > struct sdhci_pci_slot *slot = chip->slots[0]; > > -- > 2.6.2 >