[PATCH v1] mmc: Convert ternary operator to str_true_false() helper

[PATCH v1] mmc: Convert ternary operator to str_true_false() helper

[Li Dong]

Replace direct ternary condition check with existing helper function
str_true_false() to improve code readability and maintain consistency.

Signed-off-by: Li Dong <lidong@vivo.com>
---
 drivers/mmc/host/atmel-mci.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
index 0e0666c0bb6e..1f11626c8f47 100644
--- a/drivers/mmc/host/atmel-mci.c
+++ b/drivers/mmc/host/atmel-mci.c
@@ -38,6 +38,7 @@
 #include <asm/cacheflush.h>
 #include <asm/io.h>
 #include <linux/unaligned.h>
+#include <linux/string_choices.h>
 
 #define ATMCI_MAX_NR_SLOTS	2
 
@@ -2264,7 +2265,7 @@ static int atmci_init_slot(struct atmel_mci *host,
 	        "slot[%u]: bus_width=%u, detect_pin=%d, "
 		"detect_is_active_high=%s, wp_pin=%d\n",
 		id, slot_data->bus_width, desc_to_gpio(slot_data->detect_pin),
-		!gpiod_is_active_low(slot_data->detect_pin) ? "true" : "false",
+		str_true_false(!gpiod_is_active_low(slot_data->detect_pin)),
 		desc_to_gpio(slot_data->wp_pin));
 
 	mmc->ops = &atmci_ops;
-- 
2.34.1

Re: [PATCH v1] mmc: Convert ternary operator to str_true_false() helper

[Krzysztof Kozlowski]

On 20/06/2025 06:35, Li Dong wrote:
> Replace direct ternary condition check with existing helper function
> str_true_false() to improve code readability and maintain consistency.
> 
> Signed-off-by: Li Dong <lidong@vivo.com>
> ---
>  drivers/mmc/host/atmel-mci.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
Why are you sending this line per patch? Not even patchset?

Is it again another run of @vivo.com submissions when you spam community
with low quality things, just because someone told you to run coccinelle?

Best regards,
Krzysztof

Re: [PATCH v1] mmc: Convert ternary operator to str_true_false() helper

[Ulf Hansson]

On Fri, 20 Jun 2025 at 06:35, Li Dong <lidong@vivo.com> wrote:
>
> Replace direct ternary condition check with existing helper function
> str_true_false() to improve code readability and maintain consistency.
>
> Signed-off-by: Li Dong <lidong@vivo.com>

Applied for next, thanks!

Note that I am applying this since $subject patch takes care of *all*
possible conversions (it just happens to one in this case) to
str_true_false() for the mmc subsystem.

Kind regards
Uffe


> ---
>  drivers/mmc/host/atmel-mci.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/atmel-mci.c
> index 0e0666c0bb6e..1f11626c8f47 100644
> --- a/drivers/mmc/host/atmel-mci.c
> +++ b/drivers/mmc/host/atmel-mci.c
> @@ -38,6 +38,7 @@
>  #include <asm/cacheflush.h>
>  #include <asm/io.h>
>  #include <linux/unaligned.h>
> +#include <linux/string_choices.h>
>
>  #define ATMCI_MAX_NR_SLOTS     2
>
> @@ -2264,7 +2265,7 @@ static int atmci_init_slot(struct atmel_mci *host,
>                 "slot[%u]: bus_width=%u, detect_pin=%d, "
>                 "detect_is_active_high=%s, wp_pin=%d\n",
>                 id, slot_data->bus_width, desc_to_gpio(slot_data->detect_pin),
> -               !gpiod_is_active_low(slot_data->detect_pin) ? "true" : "false",
> +               str_true_false(!gpiod_is_active_low(slot_data->detect_pin)),
>                 desc_to_gpio(slot_data->wp_pin));
>
>         mmc->ops = &atmci_ops;
> --
> 2.34.1
>