* [PATCH] mmc: sh_mmcif: Remove dummy PM resume callback
@ 2025-09-04 15:35 Geert Uytterhoeven
2025-09-04 16:10 ` Wolfram Sang
2025-09-12 13:34 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2025-09-04 15:35 UTC (permalink / raw)
To: Ulf Hansson, Wolfram Sang
Cc: linux-mmc, linux-renesas-soc, linux-sh, Geert Uytterhoeven
Unassigned system sleep callbacks were always treated the same as dummy
callbacks that just return zero.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/mmc/host/sh_mmcif.c | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
index 413c34585c90d57b..bf899c8e38f517d3 100644
--- a/drivers/mmc/host/sh_mmcif.c
+++ b/drivers/mmc/host/sh_mmcif.c
@@ -1579,12 +1579,7 @@ static int sh_mmcif_suspend(struct device *dev)
return 0;
}
-static int sh_mmcif_resume(struct device *dev)
-{
- return 0;
-}
-
-static DEFINE_SIMPLE_DEV_PM_OPS(sh_mmcif_dev_pm_ops, sh_mmcif_suspend, sh_mmcif_resume);
+static DEFINE_SIMPLE_DEV_PM_OPS(sh_mmcif_dev_pm_ops, sh_mmcif_suspend, NULL);
static struct platform_driver sh_mmcif_driver = {
.probe = sh_mmcif_probe,
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sh_mmcif: Remove dummy PM resume callback
2025-09-04 15:35 [PATCH] mmc: sh_mmcif: Remove dummy PM resume callback Geert Uytterhoeven
@ 2025-09-04 16:10 ` Wolfram Sang
2025-09-12 13:34 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2025-09-04 16:10 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Ulf Hansson, linux-mmc, linux-renesas-soc, linux-sh
On Thu, Sep 04, 2025 at 05:35:43PM +0200, Geert Uytterhoeven wrote:
> Unassigned system sleep callbacks were always treated the same as dummy
> callbacks that just return zero.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sh_mmcif: Remove dummy PM resume callback
2025-09-04 15:35 [PATCH] mmc: sh_mmcif: Remove dummy PM resume callback Geert Uytterhoeven
2025-09-04 16:10 ` Wolfram Sang
@ 2025-09-12 13:34 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2025-09-12 13:34 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Wolfram Sang, linux-mmc, linux-renesas-soc, linux-sh
On Thu, 4 Sept 2025 at 17:35, Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> Unassigned system sleep callbacks were always treated the same as dummy
> callbacks that just return zero.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied for next, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sh_mmcif.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c
> index 413c34585c90d57b..bf899c8e38f517d3 100644
> --- a/drivers/mmc/host/sh_mmcif.c
> +++ b/drivers/mmc/host/sh_mmcif.c
> @@ -1579,12 +1579,7 @@ static int sh_mmcif_suspend(struct device *dev)
> return 0;
> }
>
> -static int sh_mmcif_resume(struct device *dev)
> -{
> - return 0;
> -}
> -
> -static DEFINE_SIMPLE_DEV_PM_OPS(sh_mmcif_dev_pm_ops, sh_mmcif_suspend, sh_mmcif_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(sh_mmcif_dev_pm_ops, sh_mmcif_suspend, NULL);
>
> static struct platform_driver sh_mmcif_driver = {
> .probe = sh_mmcif_probe,
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-12 13:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-04 15:35 [PATCH] mmc: sh_mmcif: Remove dummy PM resume callback Geert Uytterhoeven
2025-09-04 16:10 ` Wolfram Sang
2025-09-12 13:34 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).