[PATCH] mmc: sdhci-brcmstb: Add ARCH_BCM2835 option

[PATCH] mmc: sdhci-brcmstb: Add ARCH_BCM2835 option

[Peter Robinson]

The Raspberry Pi devices have to date all used ARCH_BCM2835
as their SoC arch dependency so configurations that use this
and not BRCMSTB won't end up with this module in their config.

Cc: Andrea della Porta <andrea.porta@suse.com>
Cc: Stefan Wahren <wahrenst@gmx.net>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>
Fixes: 40f22df5269e6 ("mmc: sdhci-brcmstb: Add BCM2712 support")
Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
---
 drivers/mmc/host/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
index bb0d4fb0892ae..eb3ecfe055910 100644
--- a/drivers/mmc/host/Kconfig
+++ b/drivers/mmc/host/Kconfig
@@ -1016,7 +1016,7 @@ config MMC_SDHCI_MICROCHIP_PIC32
 
 config MMC_SDHCI_BRCMSTB
 	tristate "Broadcom SDIO/SD/MMC support"
-	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
+	depends on ARCH_BRCMSTB || ARCH_BCM2835 || BMIPS_GENERIC || COMPILE_TEST
 	depends on MMC_SDHCI_PLTFM
 	select MMC_CQHCI
 	default ARCH_BRCMSTB || BMIPS_GENERIC
-- 
2.45.2

Re: [PATCH] mmc: sdhci-brcmstb: Add ARCH_BCM2835 option

[Andrea della Porta]

Hi Peter,

On 08:42 Thu 20 Jun     , Peter Robinson wrote:
> The Raspberry Pi devices have to date all used ARCH_BCM2835
> as their SoC arch dependency so configurations that use this
> and not BRCMSTB won't end up with this module in their config.

AFAIK the BCM2712 (RPi5) is the only SoC of the Raspberry family
that has an MMC host controller that is more or less like the one
present on the STB line silicon. Adding ARCH_BCM2835 to the dependency
will then allow RPi<=4 to use this driver for which they do not
have the relevant hw.
If I'm correct about the aforementioned point, I'd be inclined to
avoid this change, then.

Many thanks,
Andrea

> 
> Cc: Andrea della Porta <andrea.porta@suse.com>
> Cc: Stefan Wahren <wahrenst@gmx.net>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Fixes: 40f22df5269e6 ("mmc: sdhci-brcmstb: Add BCM2712 support")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> ---
>  drivers/mmc/host/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index bb0d4fb0892ae..eb3ecfe055910 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1016,7 +1016,7 @@ config MMC_SDHCI_MICROCHIP_PIC32
>  
>  config MMC_SDHCI_BRCMSTB
>  	tristate "Broadcom SDIO/SD/MMC support"
> -	depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> +	depends on ARCH_BRCMSTB || ARCH_BCM2835 || BMIPS_GENERIC || COMPILE_TEST
>  	depends on MMC_SDHCI_PLTFM
>  	select MMC_CQHCI
>  	default ARCH_BRCMSTB || BMIPS_GENERIC
> -- 
> 2.45.2
> 

Re: [PATCH] mmc: sdhci-brcmstb: Add ARCH_BCM2835 option

[Peter Robinson]

Hi Andrea,

> On 08:42 Thu 20 Jun     , Peter Robinson wrote:
> > The Raspberry Pi devices have to date all used ARCH_BCM2835
> > as their SoC arch dependency so configurations that use this
> > and not BRCMSTB won't end up with this module in their config.
>
> AFAIK the BCM2712 (RPi5) is the only SoC of the Raspberry family
> that has an MMC host controller that is more or less like the one
> present on the STB line silicon. Adding ARCH_BCM2835 to the dependency
> will then allow RPi<=4 to use this driver for which they do not
> have the relevant hw.

It won't use the driver due to the different compatibles, it just
allows the driver to be available. The various different gens of RPi
now have around 4 different types of MMC controller in use.

> If I'm correct about the aforementioned point, I'd be inclined to
> avoid this change, then.
>
> Many thanks,
> Andrea
>
> >
> > Cc: Andrea della Porta <andrea.porta@suse.com>
> > Cc: Stefan Wahren <wahrenst@gmx.net>
> > Cc: Adrian Hunter <adrian.hunter@intel.com>
> > Cc: Ulf Hansson <ulf.hansson@linaro.org>
> > Fixes: 40f22df5269e6 ("mmc: sdhci-brcmstb: Add BCM2712 support")
> > Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> > ---
> >  drivers/mmc/host/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > index bb0d4fb0892ae..eb3ecfe055910 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -1016,7 +1016,7 @@ config MMC_SDHCI_MICROCHIP_PIC32
> >
> >  config MMC_SDHCI_BRCMSTB
> >       tristate "Broadcom SDIO/SD/MMC support"
> > -     depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> > +     depends on ARCH_BRCMSTB || ARCH_BCM2835 || BMIPS_GENERIC || COMPILE_TEST
> >       depends on MMC_SDHCI_PLTFM
> >       select MMC_CQHCI
> >       default ARCH_BRCMSTB || BMIPS_GENERIC
> > --
> > 2.45.2
> >

Re: [PATCH] mmc: sdhci-brcmstb: Add ARCH_BCM2835 option

[Andrea della Porta]

Hi Peter,

On 13:22 Thu 20 Jun     , Peter Robinson wrote:
> Hi Andrea,
> 
> > On 08:42 Thu 20 Jun     , Peter Robinson wrote:
> > > The Raspberry Pi devices have to date all used ARCH_BCM2835
> > > as their SoC arch dependency so configurations that use this
> > > and not BRCMSTB won't end up with this module in their config.
> >
> > AFAIK the BCM2712 (RPi5) is the only SoC of the Raspberry family
> > that has an MMC host controller that is more or less like the one
> > present on the STB line silicon. Adding ARCH_BCM2835 to the dependency
> > will then allow RPi<=4 to use this driver for which they do not
> > have the relevant hw.
> 
> It won't use the driver due to the different compatibles, it just
> allows the driver to be available. The various different gens of RPi
> now have around 4 different types of MMC controller in use.

True, so why make a driver available if I can't use it anyway? No other
SoC served by ARCH_BCM2835 have that hw, but as you said, every one of them 
have different controllers best served by anything else but SDHCI_BRCMSTB.

Thanks,
Andrea

> 
> > If I'm correct about the aforementioned point, I'd be inclined to
> > avoid this change, then.
> >
> > Many thanks,
> > Andrea
> >
> > >
> > > Cc: Andrea della Porta <andrea.porta@suse.com>
> > > Cc: Stefan Wahren <wahrenst@gmx.net>
> > > Cc: Adrian Hunter <adrian.hunter@intel.com>
> > > Cc: Ulf Hansson <ulf.hansson@linaro.org>
> > > Fixes: 40f22df5269e6 ("mmc: sdhci-brcmstb: Add BCM2712 support")
> > > Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> > > ---
> > >  drivers/mmc/host/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > > index bb0d4fb0892ae..eb3ecfe055910 100644
> > > --- a/drivers/mmc/host/Kconfig
> > > +++ b/drivers/mmc/host/Kconfig
> > > @@ -1016,7 +1016,7 @@ config MMC_SDHCI_MICROCHIP_PIC32
> > >
> > >  config MMC_SDHCI_BRCMSTB
> > >       tristate "Broadcom SDIO/SD/MMC support"
> > > -     depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> > > +     depends on ARCH_BRCMSTB || ARCH_BCM2835 || BMIPS_GENERIC || COMPILE_TEST
> > >       depends on MMC_SDHCI_PLTFM
> > >       select MMC_CQHCI
> > >       default ARCH_BRCMSTB || BMIPS_GENERIC
> > > --
> > > 2.45.2
> > >

Re: [PATCH] mmc: sdhci-brcmstb: Add ARCH_BCM2835 option

[Peter Robinson]

On Thu, 20 Jun 2024 at 13:29, Andrea della Porta <andrea.porta@suse.com> wrote:
>
> Hi Peter,
>
> On 13:22 Thu 20 Jun     , Peter Robinson wrote:
> > Hi Andrea,
> >
> > > On 08:42 Thu 20 Jun     , Peter Robinson wrote:
> > > > The Raspberry Pi devices have to date all used ARCH_BCM2835
> > > > as their SoC arch dependency so configurations that use this
> > > > and not BRCMSTB won't end up with this module in their config.
> > >
> > > AFAIK the BCM2712 (RPi5) is the only SoC of the Raspberry family
> > > that has an MMC host controller that is more or less like the one
> > > present on the STB line silicon. Adding ARCH_BCM2835 to the dependency
> > > will then allow RPi<=4 to use this driver for which they do not
> > > have the relevant hw.
> >
> > It won't use the driver due to the different compatibles, it just
> > allows the driver to be available. The various different gens of RPi
> > now have around 4 different types of MMC controller in use.
>
> True, so why make a driver available if I can't use it anyway? No other
> SoC served by ARCH_BCM2835 have that hw, but as you said, every one of them
> have different controllers best served by anything else but SDHCI_BRCMSTB.

We, at least in Fedora, don't enable ARCH_BRCMSTB as it brings a lot
of HW and drivers we can't support.


> Thanks,
> Andrea
>
> >
> > > If I'm correct about the aforementioned point, I'd be inclined to
> > > avoid this change, then.
> > >
> > > Many thanks,
> > > Andrea
> > >
> > > >
> > > > Cc: Andrea della Porta <andrea.porta@suse.com>
> > > > Cc: Stefan Wahren <wahrenst@gmx.net>
> > > > Cc: Adrian Hunter <adrian.hunter@intel.com>
> > > > Cc: Ulf Hansson <ulf.hansson@linaro.org>
> > > > Fixes: 40f22df5269e6 ("mmc: sdhci-brcmstb: Add BCM2712 support")
> > > > Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> > > > ---
> > > >  drivers/mmc/host/Kconfig | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > > > index bb0d4fb0892ae..eb3ecfe055910 100644
> > > > --- a/drivers/mmc/host/Kconfig
> > > > +++ b/drivers/mmc/host/Kconfig
> > > > @@ -1016,7 +1016,7 @@ config MMC_SDHCI_MICROCHIP_PIC32
> > > >
> > > >  config MMC_SDHCI_BRCMSTB
> > > >       tristate "Broadcom SDIO/SD/MMC support"
> > > > -     depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> > > > +     depends on ARCH_BRCMSTB || ARCH_BCM2835 || BMIPS_GENERIC || COMPILE_TEST
> > > >       depends on MMC_SDHCI_PLTFM
> > > >       select MMC_CQHCI
> > > >       default ARCH_BRCMSTB || BMIPS_GENERIC
> > > > --
> > > > 2.45.2
> > > >

Re: [PATCH] mmc: sdhci-brcmstb: Add ARCH_BCM2835 option

[Andrea della Porta]

Hi Peter, 

On 14:03 Thu 20 Jun     , Peter Robinson wrote:
> On Thu, 20 Jun 2024 at 13:29, Andrea della Porta <andrea.porta@suse.com> wrote:
> >
> > Hi Peter,
> >
> > On 13:22 Thu 20 Jun     , Peter Robinson wrote:
> > > Hi Andrea,
> > >
> > > > On 08:42 Thu 20 Jun     , Peter Robinson wrote:
> > > > > The Raspberry Pi devices have to date all used ARCH_BCM2835
> > > > > as their SoC arch dependency so configurations that use this
> > > > > and not BRCMSTB won't end up with this module in their config.
> > > >
> > > > AFAIK the BCM2712 (RPi5) is the only SoC of the Raspberry family
> > > > that has an MMC host controller that is more or less like the one
> > > > present on the STB line silicon. Adding ARCH_BCM2835 to the dependency
> > > > will then allow RPi<=4 to use this driver for which they do not
> > > > have the relevant hw.
> > >
> > > It won't use the driver due to the different compatibles, it just
> > > allows the driver to be available. The various different gens of RPi
> > > now have around 4 different types of MMC controller in use.
> >
> > True, so why make a driver available if I can't use it anyway? No other
> > SoC served by ARCH_BCM2835 have that hw, but as you said, every one of them
> > have different controllers best served by anything else but SDHCI_BRCMSTB.
> 
> We, at least in Fedora, don't enable ARCH_BRCMSTB as it brings a lot
> of HW and drivers we can't support.

I see the point. It makes sense to me and after all there seems to be no
drawback except maybe including some drivers that cannot be used on all platforms,
but as you stated they wouldn't be loaded anyway unless put into devicetree.
After all those drivers will be compiled in anyway due to current default config
options, and on several platforms won't be usable still.

Thanks.

Reviewed-by: Andrea della Porta <andrea.porta@suse.com>
 
> 
> > Thanks,
> > Andrea
> >
> > >
> > > > If I'm correct about the aforementioned point, I'd be inclined to
> > > > avoid this change, then.
> > > >
> > > > Many thanks,
> > > > Andrea
> > > >
> > > > >
> > > > > Cc: Andrea della Porta <andrea.porta@suse.com>
> > > > > Cc: Stefan Wahren <wahrenst@gmx.net>
> > > > > Cc: Adrian Hunter <adrian.hunter@intel.com>
> > > > > Cc: Ulf Hansson <ulf.hansson@linaro.org>
> > > > > Fixes: 40f22df5269e6 ("mmc: sdhci-brcmstb: Add BCM2712 support")
> > > > > Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> > > > > ---
> > > > >  drivers/mmc/host/Kconfig | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> > > > > index bb0d4fb0892ae..eb3ecfe055910 100644
> > > > > --- a/drivers/mmc/host/Kconfig
> > > > > +++ b/drivers/mmc/host/Kconfig
> > > > > @@ -1016,7 +1016,7 @@ config MMC_SDHCI_MICROCHIP_PIC32
> > > > >
> > > > >  config MMC_SDHCI_BRCMSTB
> > > > >       tristate "Broadcom SDIO/SD/MMC support"
> > > > > -     depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> > > > > +     depends on ARCH_BRCMSTB || ARCH_BCM2835 || BMIPS_GENERIC || COMPILE_TEST
> > > > >       depends on MMC_SDHCI_PLTFM
> > > > >       select MMC_CQHCI
> > > > >       default ARCH_BRCMSTB || BMIPS_GENERIC
> > > > > --
> > > > > 2.45.2
> > > > >

Re: [PATCH] mmc: sdhci-brcmstb: Add ARCH_BCM2835 option

[Ulf Hansson]

On Thu, 20 Jun 2024 at 09:42, Peter Robinson <pbrobinson@gmail.com> wrote:
>
> The Raspberry Pi devices have to date all used ARCH_BCM2835
> as their SoC arch dependency so configurations that use this
> and not BRCMSTB won't end up with this module in their config.
>
> Cc: Andrea della Porta <andrea.porta@suse.com>
> Cc: Stefan Wahren <wahrenst@gmx.net>
> Cc: Adrian Hunter <adrian.hunter@intel.com>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Fixes: 40f22df5269e6 ("mmc: sdhci-brcmstb: Add BCM2712 support")
> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>

Applied for next, thanks!

Kind regards
Uffe


> ---
>  drivers/mmc/host/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index bb0d4fb0892ae..eb3ecfe055910 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -1016,7 +1016,7 @@ config MMC_SDHCI_MICROCHIP_PIC32
>
>  config MMC_SDHCI_BRCMSTB
>         tristate "Broadcom SDIO/SD/MMC support"
> -       depends on ARCH_BRCMSTB || BMIPS_GENERIC || COMPILE_TEST
> +       depends on ARCH_BRCMSTB || ARCH_BCM2835 || BMIPS_GENERIC || COMPILE_TEST
>         depends on MMC_SDHCI_PLTFM
>         select MMC_CQHCI
>         default ARCH_BRCMSTB || BMIPS_GENERIC
> --
> 2.45.2
>