From: Ulf Hansson <ulf.hansson@linaro.org>
To: Dong Aisheng <b29396@freescale.com>
Cc: linux-mmc <linux-mmc@vger.kernel.org>,
Chris Ball <cjb@laptop.org>,
anton@enomsg.org, Shawn Guo <shawn.guo@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Sascha Hauer <s.hauer@pengutronix.de>
Subject: Re: [PATCH 0/8] mmc: sdhci-esdhc-imx: add SD3.0 support
Date: Thu, 5 Sep 2013 09:42:14 +0200 [thread overview]
Message-ID: <CAPDyKFprH0dixTojis63R0oho6CLaPuzSVDuPia6HWQ6cLYmNA@mail.gmail.com> (raw)
In-Reply-To: <1378299257-2980-1-git-send-email-b29396@freescale.com>
On 4 September 2013 14:54, Dong Aisheng <b29396@freescale.com> wrote:
> This patch series add SD3.0 support for i.MX6Q/DL.
> Since freescale i.MX6Q/DL uSDHC clock tuning progress is a little different from
> the standard tuning process defined in host controller spec v3.0.
> So we add a hook to allow execute platform specific tuning instead of
> standard host controller tuning.
>
> The main difference are:
> 1) not only generate Buffer Read Ready interrupt when tuning is performing.
> It generates all other DATA interrupts like the normal data command.
> 2) SDHCI_CTRL_EXEC_TUNING is not automatically cleared by HW,
> instead it's controlled by SW.
> 3) SDHCI_CTRL_TUNED_CLK is not automatically set by HW,
> it's controlled by SW.
> 4) the clock delay for every tuning is set by SW.
An overall question. Do you have any thoughts around periodic/idle
re-tuning. It is has nothing directly to do with this patchset, but
since you implemented the tuning sequence here, maybe you have some
thoughts around it?
Kind regards
Ulf Hansson
>
> Tested on i.MX6Q Sabreauto board.
>
> The series is based on latest Linus tree.
>
> Dong Aisheng (8):
> mmc: sdhci: add hooks for platform specific tuning
> mmc: sdhci: allow platform access of sdhci_send_command
> sdhci: sdhci-esdhc-imx: support real clock on and off for imx6q
> sdhci: sdhci-esdhci-imx: add sd3.0 clock tuning support
> sdhci: sdhci-esdhc-imx: change pinctrl state according to uhs mode
> mmc: sdhci-esdhc: correct pre_div for imx6q
> mmc: sdhci-esdhc: set actual_clock in clock setting
> ARM: dts: imx6qdl: add uhs pinctrl state for usdhc3
>
> arch/arm/boot/dts/imx6dl.dtsi | 33 +++
> arch/arm/boot/dts/imx6q.dtsi | 33 +++
> arch/arm/boot/dts/imx6qdl-sabreauto.dtsi | 4 +-
> drivers/mmc/host/sdhci-esdhc-imx.c | 307 ++++++++++++++++++++++++++-
> drivers/mmc/host/sdhci-esdhc.h | 35 +++-
> drivers/mmc/host/sdhci.c | 12 +-
> drivers/mmc/host/sdhci.h | 3 +
> include/linux/platform_data/mmc-esdhc-imx.h | 4 +
> 8 files changed, 419 insertions(+), 12 deletions(-)
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2013-09-05 7:42 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-04 12:54 [PATCH 0/8] mmc: sdhci-esdhc-imx: add SD3.0 support Dong Aisheng
2013-09-04 12:54 ` [PATCH 1/8] mmc: sdhci: add hooks for platform specific tuning Dong Aisheng
2013-09-05 3:14 ` Shawn Guo
2013-09-05 14:53 ` Dong Aisheng
2013-09-04 12:54 ` [PATCH 2/8] mmc: sdhci: allow platform access of sdhci_send_command Dong Aisheng
2013-09-04 12:54 ` [PATCH 3/8] sdhci: sdhci-esdhc-imx: support real clock on and off for imx6q Dong Aisheng
2013-09-05 4:32 ` Shawn Guo
2013-09-05 14:59 ` Dong Aisheng
2013-09-04 12:54 ` [PATCH 4/8] sdhci: sdhci-esdhci-imx: add sd3.0 clock tuning support Dong Aisheng
2013-09-05 6:00 ` Shawn Guo
2013-09-05 15:02 ` Dong Aisheng
2013-09-05 7:33 ` Ulf Hansson
2013-09-05 17:52 ` Dong Aisheng
2013-09-16 7:48 ` Ulf Hansson
2013-09-04 12:54 ` [PATCH 5/8] sdhci: sdhci-esdhc-imx: change pinctrl state according to uhs mode Dong Aisheng
2013-09-05 6:34 ` Shawn Guo
2013-09-05 15:06 ` Dong Aisheng
2013-09-05 7:38 ` Ulf Hansson
2013-09-05 16:04 ` Dong Aisheng
2013-09-13 14:01 ` Ulf Hansson
2013-09-13 16:38 ` Dong Aisheng
2013-09-05 18:40 ` Matt Sealey
2013-09-11 9:26 ` Dong Aisheng
2013-09-27 0:28 ` Matt Sealey
2013-09-04 12:54 ` [PATCH 6/8] mmc: sdhci-esdhc: correct pre_div for imx6q Dong Aisheng
2013-09-04 12:54 ` [PATCH 7/8] mmc: sdhci-esdhc: set actual_clock in clock setting Dong Aisheng
2013-09-04 12:54 ` [PATCH 8/8] ARM: dts: imx6qdl: add uhs pinctrl state for usdhc3 Dong Aisheng
2013-09-05 6:43 ` Shawn Guo
2013-09-05 15:09 ` Dong Aisheng
2013-09-05 8:03 ` Sascha Hauer
2013-09-05 15:29 ` Dong Aisheng
2013-09-05 7:42 ` Ulf Hansson [this message]
2013-09-05 18:01 ` [PATCH 0/8] mmc: sdhci-esdhc-imx: add SD3.0 support Dong Aisheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFprH0dixTojis63R0oho6CLaPuzSVDuPia6HWQ6cLYmNA@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=anton@enomsg.org \
--cc=b29396@freescale.com \
--cc=cjb@laptop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).