From: Ulf Hansson <ulf.hansson@linaro.org>
To: Christoph Hellwig <hch@lst.de>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-mmc <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH] mmc/android-goldfish: remove incorrect __iomem annotation
Date: Tue, 1 Sep 2015 14:23:33 +0200 [thread overview]
Message-ID: <CAPDyKFqAm5QBzBRSXQLy_chNLd63Y3cr9AKikxu-MrJQcJwyrg@mail.gmail.com> (raw)
In-Reply-To: <1439798966-16277-1-git-send-email-hch@lst.de>
+linux-mmc
-Chris (don't maintain mmc no more)
On 17 August 2015 at 10:09, Christoph Hellwig <hch@lst.de> wrote:
> Make sparse happy:
>
> drivers/mmc/host/android-goldfish.c:535:56: sparse: incorrect type in argument 3 (different address spaces)
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Normally I like you to post mmc patces to the linux-mmc list. As this
is a trivial patch and the driver don't have a dedicated maintainer, I
am going to pick it up anyway.
Thanks, applied for next!
Kind regards
Uffe
> ---
> drivers/mmc/host/android-goldfish.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/android-goldfish.c b/drivers/mmc/host/android-goldfish.c
> index b1eac71..dca5518 100644
> --- a/drivers/mmc/host/android-goldfish.c
> +++ b/drivers/mmc/host/android-goldfish.c
> @@ -118,7 +118,7 @@ struct goldfish_mmc_host {
> struct mmc_host *mmc;
> struct device *dev;
> unsigned char id; /* 16xx chips have 2 MMC blocks */
> - void __iomem *virt_base;
> + void *virt_base;
> unsigned int phys_base;
> int irq;
> unsigned char bus_mode;
> --
> 1.9.1
>
parent reply other threads:[~2015-09-01 12:23 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1439798966-16277-1-git-send-email-hch@lst.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFqAm5QBzBRSXQLy_chNLd63Y3cr9AKikxu-MrJQcJwyrg@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).