From: Ulf Hansson <ulf.hansson@linaro.org>
To: Tony Lindgren <tony@atomide.com>
Cc: Shawn Lin <shawn.lin@rock-chips.com>,
linux-omap <linux-omap@vger.kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] mmc: core: Fix debounce time to use microseconds
Date: Thu, 27 Sep 2018 01:47:44 +0200 [thread overview]
Message-ID: <CAPDyKFqOYNAC5GHPsWbganZ7BjHD67OSqrxxCwu1nXzrLRhFMw@mail.gmail.com> (raw)
In-Reply-To: <20180918231656.21778-1-tony@atomide.com>
On 19 September 2018 at 01:16, Tony Lindgren <tony@atomide.com> wrote:
> The debounce value in device tree is in milliseconds but needs to be in
> microseconds for mmc_gpiod_request_cd().
>
> Fixes: bfd694d5e21c ("mmc: core: Add tunable delay before detecting card
> after card is inserted")
> Cc: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
Applied for fixes, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/core/host.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> --- a/drivers/mmc/core/host.c
> +++ b/drivers/mmc/core/host.c
> @@ -235,7 +235,7 @@ int mmc_of_parse(struct mmc_host *host)
> host->caps |= MMC_CAP_NEEDS_POLL;
>
> ret = mmc_gpiod_request_cd(host, "cd", 0, true,
> - cd_debounce_delay_ms,
> + cd_debounce_delay_ms * 1000,
> &cd_gpio_invert);
> if (!ret)
> dev_info(host->parent, "Got CD GPIO\n");
> --
> 2.19.0
prev parent reply other threads:[~2018-09-26 23:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 23:16 [PATCH] mmc: core: Fix debounce time to use microseconds Tony Lindgren
2018-09-26 23:47 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFqOYNAC5GHPsWbganZ7BjHD67OSqrxxCwu1nXzrLRhFMw@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).