From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ulf Hansson Subject: Re: [PATCH] mmc: core: Fix debounce time to use microseconds Date: Thu, 27 Sep 2018 01:47:44 +0200 Message-ID: References: <20180918231656.21778-1-tony@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180918231656.21778-1-tony@atomide.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Tony Lindgren Cc: Shawn Lin , linux-omap , "linux-mmc@vger.kernel.org" , Linux ARM List-Id: linux-mmc@vger.kernel.org On 19 September 2018 at 01:16, Tony Lindgren wrote: > The debounce value in device tree is in milliseconds but needs to be in > microseconds for mmc_gpiod_request_cd(). > > Fixes: bfd694d5e21c ("mmc: core: Add tunable delay before detecting card > after card is inserted") > Cc: Shawn Lin > Signed-off-by: Tony Lindgren Applied for fixes, thanks! Kind regards Uffe > --- > drivers/mmc/core/host.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c > --- a/drivers/mmc/core/host.c > +++ b/drivers/mmc/core/host.c > @@ -235,7 +235,7 @@ int mmc_of_parse(struct mmc_host *host) > host->caps |= MMC_CAP_NEEDS_POLL; > > ret = mmc_gpiod_request_cd(host, "cd", 0, true, > - cd_debounce_delay_ms, > + cd_debounce_delay_ms * 1000, > &cd_gpio_invert); > if (!ret) > dev_info(host->parent, "Got CD GPIO\n"); > -- > 2.19.0