From: Ulf Hansson <ulf.hansson@linaro.org>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mmc: sdhci: use FIELD_GET/PREP for current capabilities bit masks
Date: Fri, 15 May 2020 09:09:18 +0200 [thread overview]
Message-ID: <CAPDyKFqVHMdBwZHDvTC-XkTbBiobEdBFjnjpcgoPoU5rirWWMQ@mail.gmail.com> (raw)
In-Reply-To: <20200511062828.1791484-1-yamada.masahiro@socionext.com>
On Mon, 11 May 2020 at 08:29, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
>
> Use FIELD_GET and FIELD_PREP to get access to the register fields. Delete
> the shift macros and use GENMASK() for the touched macros.
>
> Note that, this has the side-effect of changing the constants to 64-bit on
> 64-bit platforms.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Applied for next, thanks!
Kind regards
Uffe
> ---
>
> drivers/mmc/host/sdhci-esdhc-imx.c | 6 +++---
> drivers/mmc/host/sdhci.c | 27 ++++++++++++---------------
> drivers/mmc/host/sdhci.h | 11 ++++-------
> 3 files changed, 19 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
> index 38cd83118082..9896e03fce71 100644
> --- a/drivers/mmc/host/sdhci-esdhc-imx.c
> +++ b/drivers/mmc/host/sdhci-esdhc-imx.c
> @@ -419,9 +419,9 @@ static u32 esdhc_readl_le(struct sdhci_host *host, int reg)
>
> if (unlikely(reg == SDHCI_MAX_CURRENT) && esdhc_is_usdhc(imx_data)) {
> val = 0;
> - val |= 0xFF << SDHCI_MAX_CURRENT_330_SHIFT;
> - val |= 0xFF << SDHCI_MAX_CURRENT_300_SHIFT;
> - val |= 0xFF << SDHCI_MAX_CURRENT_180_SHIFT;
> + val |= FIELD_PREP(SDHCI_MAX_CURRENT_330_MASK, 0xFF);
> + val |= FIELD_PREP(SDHCI_MAX_CURRENT_300_MASK, 0xFF);
> + val |= FIELD_PREP(SDHCI_MAX_CURRENT_180_MASK, 0xFF);
> }
>
> if (unlikely(reg == SDHCI_INT_STATUS)) {
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 344a7e0e33fe..7818e650f974 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -4355,35 +4355,32 @@ int sdhci_setup_host(struct sdhci_host *host)
>
> curr = min_t(u32, curr, SDHCI_MAX_CURRENT_LIMIT);
> max_current_caps =
> - (curr << SDHCI_MAX_CURRENT_330_SHIFT) |
> - (curr << SDHCI_MAX_CURRENT_300_SHIFT) |
> - (curr << SDHCI_MAX_CURRENT_180_SHIFT);
> + FIELD_PREP(SDHCI_MAX_CURRENT_330_MASK, curr) |
> + FIELD_PREP(SDHCI_MAX_CURRENT_300_MASK, curr) |
> + FIELD_PREP(SDHCI_MAX_CURRENT_180_MASK, curr);
> }
> }
>
> if (host->caps & SDHCI_CAN_VDD_330) {
> ocr_avail |= MMC_VDD_32_33 | MMC_VDD_33_34;
>
> - mmc->max_current_330 = ((max_current_caps &
> - SDHCI_MAX_CURRENT_330_MASK) >>
> - SDHCI_MAX_CURRENT_330_SHIFT) *
> - SDHCI_MAX_CURRENT_MULTIPLIER;
> + mmc->max_current_330 = FIELD_GET(SDHCI_MAX_CURRENT_330_MASK,
> + max_current_caps) *
> + SDHCI_MAX_CURRENT_MULTIPLIER;
> }
> if (host->caps & SDHCI_CAN_VDD_300) {
> ocr_avail |= MMC_VDD_29_30 | MMC_VDD_30_31;
>
> - mmc->max_current_300 = ((max_current_caps &
> - SDHCI_MAX_CURRENT_300_MASK) >>
> - SDHCI_MAX_CURRENT_300_SHIFT) *
> - SDHCI_MAX_CURRENT_MULTIPLIER;
> + mmc->max_current_300 = FIELD_GET(SDHCI_MAX_CURRENT_300_MASK,
> + max_current_caps) *
> + SDHCI_MAX_CURRENT_MULTIPLIER;
> }
> if (host->caps & SDHCI_CAN_VDD_180) {
> ocr_avail |= MMC_VDD_165_195;
>
> - mmc->max_current_180 = ((max_current_caps &
> - SDHCI_MAX_CURRENT_180_MASK) >>
> - SDHCI_MAX_CURRENT_180_SHIFT) *
> - SDHCI_MAX_CURRENT_MULTIPLIER;
> + mmc->max_current_180 = FIELD_GET(SDHCI_MAX_CURRENT_180_MASK,
> + max_current_caps) *
> + SDHCI_MAX_CURRENT_MULTIPLIER;
> }
>
> /* If OCR set by host, use it instead. */
> diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
> index d7f1441b0fc3..2ff98891bf25 100644
> --- a/drivers/mmc/host/sdhci.h
> +++ b/drivers/mmc/host/sdhci.h
> @@ -233,13 +233,10 @@
> #define SDHCI_SUPPORT_HS400 0x80000000 /* Non-standard */
>
> #define SDHCI_MAX_CURRENT 0x48
> -#define SDHCI_MAX_CURRENT_LIMIT 0xFF
> -#define SDHCI_MAX_CURRENT_330_MASK 0x0000FF
> -#define SDHCI_MAX_CURRENT_330_SHIFT 0
> -#define SDHCI_MAX_CURRENT_300_MASK 0x00FF00
> -#define SDHCI_MAX_CURRENT_300_SHIFT 8
> -#define SDHCI_MAX_CURRENT_180_MASK 0xFF0000
> -#define SDHCI_MAX_CURRENT_180_SHIFT 16
> +#define SDHCI_MAX_CURRENT_LIMIT GENMASK(7, 0)
> +#define SDHCI_MAX_CURRENT_330_MASK GENMASK(7, 0)
> +#define SDHCI_MAX_CURRENT_300_MASK GENMASK(15, 8)
> +#define SDHCI_MAX_CURRENT_180_MASK GENMASK(23, 16)
> #define SDHCI_MAX_CURRENT_MULTIPLIER 4
>
> /* 4C-4F reserved for more max current */
> --
> 2.25.1
>
prev parent reply other threads:[~2020-05-15 7:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 6:28 [PATCH] mmc: sdhci: use FIELD_GET/PREP for current capabilities bit masks Masahiro Yamada
2020-05-15 7:09 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFqVHMdBwZHDvTC-XkTbBiobEdBFjnjpcgoPoU5rirWWMQ@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).