Re: [PATCH RFC 27/35] memstick: drop nth_page() usage within SG entry

[Ulf Hansson <ulf.hansson@linaro.org>]

- trimmed cc-list

On Thu, 21 Aug 2025 at 22:08, David Hildenbrand <david@redhat.com> wrote:
>
> It's no longer required to use nth_page() when iterating pages within a
> single SG entry, so let's drop the nth_page() usage.
>
> Cc: Maxim Levitsky <maximlevitsky@gmail.com>
> Cc: Alex Dubov <oakad@yahoo.com>
> Cc: Ulf Hansson <ulf.hansson@linaro.org>
> Signed-off-by: David Hildenbrand <david@redhat.com>

Acked-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe



> ---
>  drivers/memstick/host/jmb38x_ms.c | 3 +--
>  drivers/memstick/host/tifm_ms.c   | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c
> index cddddb3a5a27f..c5e71d39ffd51 100644
> --- a/drivers/memstick/host/jmb38x_ms.c
> +++ b/drivers/memstick/host/jmb38x_ms.c
> @@ -317,8 +317,7 @@ static int jmb38x_ms_transfer_data(struct jmb38x_ms_host *host)
>                 unsigned int p_off;
>
>                 if (host->req->long_data) {
> -                       pg = nth_page(sg_page(&host->req->sg),
> -                                     off >> PAGE_SHIFT);
> +                       pg = sg_page(&host->req->sg) + off / PAGE_SIZE;
>                         p_off = offset_in_page(off);
>                         p_cnt = PAGE_SIZE - p_off;
>                         p_cnt = min(p_cnt, length);
> diff --git a/drivers/memstick/host/tifm_ms.c b/drivers/memstick/host/tifm_ms.c
> index db7f3a088fb09..0d64184ca10a9 100644
> --- a/drivers/memstick/host/tifm_ms.c
> +++ b/drivers/memstick/host/tifm_ms.c
> @@ -201,8 +201,7 @@ static unsigned int tifm_ms_transfer_data(struct tifm_ms *host)
>                 unsigned int p_off;
>
>                 if (host->req->long_data) {
> -                       pg = nth_page(sg_page(&host->req->sg),
> -                                     off >> PAGE_SHIFT);
> +                       pg = sg_page(&host->req->sg) + off / PAGE_SIZE;
>                         p_off = offset_in_page(off);
>                         p_cnt = PAGE_SIZE - p_off;
>                         p_cnt = min(p_cnt, length);
> --
> 2.50.1
>